Closed
Bug 1329052
Opened 7 years ago
Closed 3 years ago
Make bullet frame render in color from -webkit-text-fill-color rather than color property
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
91 Branch
People
(Reporter: xidorn, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(1 file)
Currently list bullet are rendered in the color specified by color property, but I think it should be rendered in the color by -webkit-text-fill-color property like normal text. This is discussed in https://github.com/whatwg/compat/issues/71 and it seems people agree with that this is a more consistent behavior. To fix this, I think we just need to change all occurances of nsLayoutUtils::GetColor in nsBulletFrame.cpp to use nsStyleText::mWebkitTextFillColor instead of nsStyleColor::mColor.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•3 years ago
|
||
Bug 1542807 fixed this bug -- all (non-image) ::markers now render as text using our normal rendering path. I'll add a WPT for this...
Assignee: nobody → mats
Depends on: 1542807
|
||
Comment 2•3 years ago
|
||
Please do, Chromium is also wrong with symbols:
<!DOCTYPE html>
<style>
li { color: red; -webkit-text-fill-color: green; }
.symbol { list-style-type: disc;}
.decimal { list-style-type: decimal; }
.string { list-style-type: "3. "; }
.content::marker { content: "4. "; }
</style>
<ol>
<li class="symbol"></li>
<li class="decimal"></li>
<li class="string"></li>
<li class="content"></li>
</ol>
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D117962
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51d2f318ee76 Add WPT checking that ::markers honor -webkit-text-fill-color. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29473 for changes under testing/web-platform/tests
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Upstream PR merged by moz-wptsync-bot
|
||
Updated•3 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•