1329077 - Revert opening a new window hack for test_animation_performance_warning.html

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

We change test_animation_performance_warning.html to opening a new window to use requetIdleCallback in the test in bug 1328255.  Once requestIdleCallback gets shipped on all channels, we can remove the hack.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb6158c74c9bf8aba3390f613912409d850d6fa1

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1329077 - Revert the hack that opens a new window to use requestIdleCallback.

requestIdleCallback has been enable by default in bug 1314959.

Review commit: https://reviewboard.mozilla.org/r/141282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141282/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1329077 - Drop redundant waitForIdleCallback().

We have already waitForIdle() in testcommon.js.

Review commit: https://reviewboard.mozilla.org/r/141284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141284/

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8869700 [details]
Bug 1329077 - Drop redundant waitForIdleCallback().

https://reviewboard.mozilla.org/r/141284/#review144958

Comment 5

[Boris Chiou [:boris]]

Comment on attachment 8869699 [details]
Bug 1329077 - Revert the hack that opens a new window to use requestIdleCallback.

https://reviewboard.mozilla.org/r/141282/#review144962

Assuming most of code are copied, this looks good to me.

::: dom/animation/test/testcommon.js
(Diff revision 1)
> -                        "assert_greater_than_equal",
> -                        "assert_not_exists",
>                          "assert_between_inclusive",
>                          "assert_true", "assert_false",
>                          "assert_class_string", "assert_throws",
>                          "assert_unreached", "assert_regexp_match",
>                          "promise_test", "test"]) {
>      window[funcName] = opener[funcName].bind(opener);
>    }
>  
>    window.EventWatcher = opener.EventWatcher;
> -  // Used for requestLongerTimeout.
> -  window.W3CTest = opener.W3CTest;

So we can use these functions directly now, right? It seems that we still use ```assert_not_exists``` and ```requestLongerTimeout```.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

(In reply to Boris Chiou [:boris] from comment #5)
> Comment on attachment 8869699 [details]
> Bug 1329077 - Revert the hack that opens a new window to use
> requestIdleCallback.
> 
> https://reviewboard.mozilla.org/r/141282/#review144962
> 
> Assuming most of code are copied, this looks good to me.
> 
> ::: dom/animation/test/testcommon.js
> (Diff revision 1)
> > -                        "assert_greater_than_equal",
> > -                        "assert_not_exists",
> >                          "assert_between_inclusive",
> >                          "assert_true", "assert_false",
> >                          "assert_class_string", "assert_throws",
> >                          "assert_unreached", "assert_regexp_match",
> >                          "promise_test", "test"]) {
> >      window[funcName] = opener[funcName].bind(opener);
> >    }
> >  
> >    window.EventWatcher = opener.EventWatcher;
> > -  // Used for requestLongerTimeout.
> > -  window.W3CTest = opener.W3CTest;
> 
> So we can use these functions directly now, right? It seems that we still
> use ```assert_not_exists``` and ```requestLongerTimeout```.

That's right!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81e7acdb8990
Revert the hack that opens a new window to use requestIdleCallback. r=boris
https://hg.mozilla.org/integration/autoland/rev/6f7dd28f9060
Drop redundant waitForIdleCallback(). r=boris

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81e7acdb8990
https://hg.mozilla.org/mozilla-central/rev/6f7dd28f9060