Closed
Bug 1329086
Opened 7 years ago
Closed 7 years ago
Selection::ToString should flush frames
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
From bug 1328832 comment 4. Selection::ToString claims to be flushing frames, but it's only flushing style.
|
Assignee | |
Comment 1•7 years ago
|
||
FlushType::Frames is the same as FlushType::Style, so I guess this is just better documentation of intent?
Attachment #8824331 -
Flags: review?(bzbarsky)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8824331 [details] [diff] [review] patch r=me. And yes, they're the same at the moment, but in a world in which style computation is not tied to frame construction, we would make them different: Frames would imply Style but not vice-versa.
Attachment #8824331 -
Flags: review?(bzbarsky) → review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cfc41cf8b0b3 Make Selection::ToString flush frames. r=bzbarsky
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cfc41cf8b0b3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•