Closed Bug 1329098 Opened 5 years ago Closed 5 years ago

Move MediaDecoderStateMachine::DispatchDecodeTasksIfNeeded() into state objects

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

http://searchfox.org/mozilla-central/rev/568e68ade5c6e3d29abba1d1bc25fe87fa1da962/dom/media/MediaDecoderStateMachine.cpp#2976

We are able to remove some checks for mState by moving the function into the state objects.
Assignee: nobody → jwwang
Blocks: 1324999
Priority: -- → P3
Comment on attachment 8824856 [details]
Bug 1329098. Part 1 - copy DispatchDecodeTasksIfNeeded() into BufferingState.

https://reviewboard.mozilla.org/r/103160/#review103724
Attachment #8824856 - Flags: review?(kaku) → review+
Comment on attachment 8824857 [details]
Bug 1329098. Part 2 - remove unnecessary checks.

https://reviewboard.mozilla.org/r/103162/#review103726
Attachment #8824857 - Flags: review?(kaku) → review+
Comment on attachment 8824858 [details]
Bug 1329098. Part 3 - remove some temp vairables.

https://reviewboard.mozilla.org/r/103164/#review103728
Attachment #8824858 - Flags: review?(kaku) → review+
Comment on attachment 8824859 [details]
Bug 1329098. Part 4 - move DispatchDecodeTasksIfNeeded into DecodingState.

https://reviewboard.mozilla.org/r/103166/#review103730
Attachment #8824859 - Flags: review?(kaku) → review+
Comment on attachment 8824860 [details]
Bug 1329098. Part 5 - remove unnecessary checks and temps.

https://reviewboard.mozilla.org/r/103168/#review103732
Attachment #8824860 - Flags: review?(kaku) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6bd3e871b12
Part 1 - copy DispatchDecodeTasksIfNeeded() into BufferingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/17d0086ac024
Part 2 - remove unnecessary checks. r=kaku
https://hg.mozilla.org/integration/autoland/rev/e675289447f5
Part 3 - remove some temp vairables. r=kaku
https://hg.mozilla.org/integration/autoland/rev/8f579fb33b25
Part 4 - move DispatchDecodeTasksIfNeeded into DecodingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/c00b89907a83
Part 5 - remove unnecessary checks and temps. r=kaku
You need to log in before you can comment on or make changes to this bug.