1329119 - [Stylo] Reftest crash: @ mozilla::ServoRestyleManager::RecreateStyleContexts

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Shing Lyu [:shinglyu]]

layout/reftests/css-display/display-contents-acid-dyn-1.html
layout/reftests/css-display/display-contents-generated-content-2.html
layout/reftests/css-display/display-contents-generated-content.html
layout/reftests/css-display/display-contents-style-inheritance-1-dom-mutations.html

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Do you have a backtrace for this?

Comment 2

[Bobby Holley (:bholley)]

Incremental restyle.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

They're all display contents tests, I bet that's related, and we have no display contents right now as far as I know.

Comment 4

[Bobby Holley (:bholley)]

Oh I see. Probably worth solidifying the architecture a bit more before we tackle that then.

Comment 5

[Cameron McCormack (:heycam)]

Some of these are still failing.

Comment 6

[Cameron McCormack (:heycam)]

The last test from comment 0, layout/reftests/css-display/display-contents-style-inheritance-1-dom-mutations.html, times out due to lack of support for :scope rules.

Comment 7

[Chris Peterson [:cpeterson]]

Cameron, do you know if this reftest crash is still happening? Can we close this bug?

Comment 8

[Cameron McCormack (:heycam)]

display-contents-style-inheritance-1-dom-mutations.html will still time out, since the test relies on support for some Web Components features which we haven't implemented yet for Stylo.  The other tests are running fine now.  I'll close the bug.