Remove last uses of Scoped.h from PSM

RESOLVED FIXED in Firefox 53

Status

()

P1
minor
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [psm-assigned])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
PSM is almost free from uses of Scoped.h.

The only things left are in ScopedNSSTypes.h as the ScopedX NSS types, and the only consumer left is in ipc/keystore/, which is B2G specific.

We should rip out the entire ipc/keystore/ folder since we don't need to keep B2G code in m-c anymore, and rid PSM of Scoped.h entirely.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8825856 [details]
Bug 1329234 - Remove ipc/keystore/.

https://reviewboard.mozilla.org/r/103924/#review104766
Attachment #8825856 - Flags: review?(mrbkap) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8825857 [details]
Bug 1329234 - Remove last uses of Scoped.h from PSM.

https://reviewboard.mozilla.org/r/103926/#review105226
Attachment #8825857 - Flags: review?(mgoodwin) → review+
(Assignee)

Comment 5

2 years ago
Thanks for the reviews!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=344278117bb434cc677feb9bd0991b89bedd24fb
The failures look like intermittents.
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/67e09570f10a
Remove ipc/keystore/. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/4a234901b459
Remove last uses of Scoped.h from PSM. r=mgoodwin
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/67e09570f10a
https://hg.mozilla.org/mozilla-central/rev/4a234901b459
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.