1329237 - Avoid non-smart string IDL types in nsISiteSecurityService.idl

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

Smart string classes like nsCString are safer to use than raw |char*| strings, and are typically easier to deal with as well.

We should move nsISiteSecurityService.idl off non-smart string IDL types as much as possible to improve the safety of the C++ implementation.

Comment 1

[:Cykesiopka]

Attachment: Bug 1329237 - Avoid non-smart string IDL types in nsISiteSecurityService.idl.

Smart string IDL types give us nsA[C]String in C++ code, which is safer than
raw char strings.

Review commit: https://reviewboard.mozilla.org/r/103946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103946/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8825866 [details]
Bug 1329237 - Avoid non-smart string IDL types in nsISiteSecurityService.idl.

https://reviewboard.mozilla.org/r/103946/#review105022

Looks good to me.

Comment 3

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=344278117bb434cc677feb9bd0991b89bedd24fb
The failures look like intermittents.

Comment 4

[:Cykesiopka]

Comment on attachment 8825866 [details]
Bug 1329237 - Avoid non-smart string IDL types in nsISiteSecurityService.idl.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103946/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94c2a93e9024
Avoid non-smart string IDL types in nsISiteSecurityService.idl. r=keeler

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94c2a93e9024