Closed
Bug 1329237
Opened 7 years ago
Closed 7 years ago
Avoid non-smart string IDL types in nsISiteSecurityService.idl
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Smart string classes like nsCString are safer to use than raw |char*| strings, and are typically easier to deal with as well. We should move nsISiteSecurityService.idl off non-smart string IDL types as much as possible to improve the safety of the C++ implementation.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8825866 [details] Bug 1329237 - Avoid non-smart string IDL types in nsISiteSecurityService.idl. https://reviewboard.mozilla.org/r/103946/#review105022 Looks good to me.
Attachment #8825866 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=344278117bb434cc677feb9bd0991b89bedd24fb The failures look like intermittents.
Keywords: checkin-needed
| Comment hidden (mozreview-request) |
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/94c2a93e9024 Avoid non-smart string IDL types in nsISiteSecurityService.idl. r=keeler
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/94c2a93e9024
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•