|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Smart string classes like nsCString are safer to use than raw |char*| strings, and are typically easier to deal with as well. We should move nsISiteSecurityService.idl off non-smart string IDL types as much as possible to improve the safety of the C++ implementation.
Comment on attachment 8825866 [details] Bug 1329237 - Avoid non-smart string IDL types in nsISiteSecurityService.idl. https://reviewboard.mozilla.org/r/103946/#review105022 Looks good to me.
Attachment #8825866 - Flags: review?(dkeeler) → review+
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=344278117bb434cc677feb9bd0991b89bedd24fb The failures look like intermittents.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/94c2a93e9024 Avoid non-smart string IDL types in nsISiteSecurityService.idl. r=keeler
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.