Closed Bug 1329238 Opened 3 years ago Closed 3 years ago

Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

The std::unique_ptr based UniqueX types provide better safety over managing raw pointers.
Comment on attachment 8829911 [details]
Bug 1329238 - Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers.

https://reviewboard.mozilla.org/r/106858/#review108246
Attachment #8829911 - Flags: review?(ttaubert) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f97ca8be2b4
Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers. r=ttaubert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5f97ca8be2b4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.