Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers

RESOLVED FIXED in Firefox 54

Status

()

Core
Security: PSM
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The std::unique_ptr based UniqueX types provide better safety over managing raw pointers.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8829911 [details]
Bug 1329238 - Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers.

https://reviewboard.mozilla.org/r/106858/#review108246
Attachment #8829911 - Flags: review?(ttaubert) → review+

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f97ca8be2b4
Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers. r=ttaubert
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5f97ca8be2b4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.