Closed Bug 1329286 Opened 3 years ago Closed Last year
Remove |mach find-test-chunk| and related code from mochitest
I think we should remove |mach find-test-chunk| because: 1) It's currently broken with a KeyError 2) It only ever worked with mochitest-plain to begin with 3) It's kind of inconvenient to use (need to type out a lot of command line args) 4) I'm not sure anyone ever verified how accurate it is This bug will involve deleting the mach command itself, as well as removing related logic from the mochitest harness.
Also, 'mach test-info' can be used to determine where (platform/suite/chunk) any test has recently run.
:ahal - When you filed this bug, you said > ... as well as removing related logic from the mochitest harness. I don't see good candidates for removal from the mochitest harness. Were you thinking of removing support for 'dump_tests', or something like that? (It seems like a potentially useful argument.)
Attachment #9002086 - Flags: review?(ahal)
Comment on attachment 9002086 [details] [diff] [review] remove 'mach find-test-chunk' Review of attachment 9002086 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #9002086 - Flags: review?(ahal) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/fd1542982c9e Remove 'mach find-test-chunk'. r=ahal
Backed out changeset fd1542982c9e (Bug 1329286) for linting failure on builds/worker/checkouts/gecko/testing/mach_commands.py:12: Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/4e14afc3c82e3b1b179e6ad326e51f430fd69cd5 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fd1542982c9e4bb7ed60b852c738b6bc4eafb601&filter-searchStr=bb9dfc5b649a41ae167ab015349f43132de01a76&selectedJob=194845188 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194845188&repo=mozilla-inbound&lineNumber=327
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb4d9eac9c87 Remove 'mach find-test-chunk'; r=ahal
You need to log in before you can comment on or make changes to this bug.