13293 - MLK: nsHTMLContentSink (easy!)

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Bruce Mitchener]

Woops.  Caller owns this char*.  nsHTMLContentSink needs to free it.

[W] MLK: Memory leak of 51 bytes from 1 block allocated in PL_strdup
        Distribution of leaked blocks
                51 bytes from 1 block of 51 bytes (0x097d90b0) allocation number
221904
        Allocation location
            malloc         [dbgheap.c:129]
            PL_strdup      [strdup.c:30]
            nsCRT::strdup(char const*) [nsCRT.h:151]
            nsStdURL::DupString(char * *,char *) [nsStdURL.cpp:673]
            nsStdURL::GetSpec(char * *) [nsStdURL.h:93]
            HTMLContentSink::EvaluateScript(nsString&,int)
[nsHTMLContentSink.cpp:3149]
            HTMLContentSink::ProcessSCRIPTTag(nsIParserNode const&)
[nsHTMLContentSink.cpp:3323]
            HTMLContentSink::AddLeaf(nsIParserNode const&)
[nsHTMLContentSink.cpp:2176]
            CNavDTD::AddLeaf(nsIParserNode const&) [CNavDTD.cpp:2660]
            CNavDTD::HandleScriptToken(nsCParserNode&) [CNavDTD.cpp:1643]
            CNavDTD::OpenContainer(nsIParserNode const&,int) [CNavDTD.cpp:2469]
            CNavDTD::HandleDefaultStartToken(CToken *,nsHTMLTag,nsIParserNode&)
[CNavDTD.cpp:1047]
            CNavDTD::HandleStartToken(CToken *) [CNavDTD.cpp:1290]
            NavDispatchTokenHandler [CNavDTD.cpp:241]
            CTokenHandler::()(CToken *,nsIDTD *) [nsTokenHandler.cpp:80]

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Diff attached that should fix, and also remove obsolete NECKO #define switching
for a cleaner, whiter smile.  Say the word and I'll check it in.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: diff to fix

Comment 3

[vidur (gone)]

Thanks shaver and bruce. Fix checked in on 9/15/1999.

Comment 4

[Jan Carpenter]

code fix.  verifying based on developer comments.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d2bd225d53a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13293: Show Add To Collections after tabs load