1329309 - Crash in sk_sse41_new::loop<T>

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

This bug was filed from the Socorro interface and is 
report bp-1ba24e60-369f-426f-9ef8-952482170106.
=============================================================

Common crash, but stops in 51.  It could be Skia update, some fix in 52, or different set of people running release and beta.

If we don't know what fixed it, we should track and see if it shows up in 52 when that hits beta.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

#2 "DrawTargetSkia" crash.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: remove deprecated SkOpts_sse41 blits

This is just a backport of this upstream fix: https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8824539 [details] [diff] [review]
remove deprecated SkOpts_sse41 blits

Approval Request Comment
[Feature/Bug causing the regression]: bug 1246756, so 47+
[User impact if declined]: Possible crashes when rendering on CPUs with SSE 4.1.
[Is this code covered by automated tests?]: Yes, pretty much any test that does any rendering at all.
[Has the fix been verified in Nightly?]: Yes, bug 1299435 which updated us to Skia milestone55 in 52 already has this patch rolled in and we've seen no reports of these crashes on 52+.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: beta
[Is the change risky?]: No
[Why is the change risky/not risky?]: Fix is already incorporated upstream and in fixes we made in 52. It just causes us to use the same SSE2 routines that are used for everyone else instead of the specialized SSE4.1 routines.
[String changes made/needed]: None

Comment 4

[Liz Henry (:lizzard)]

Comment on attachment 8824539 [details] [diff] [review]
remove deprecated SkOpts_sse41 blits

Crash fix for beta only. This should make it into the 51 beta 13 build today.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce55e4d27603

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3218ea763746

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'sk_sse41_new::loop<T>':
 - nightly (version 53): 0 crashes from 2016-11-14.
 - aurora  (version 52): 0 crashes from 2016-11-14.
 - beta    (version 51): 236 crashes from 2016-11-14.
 - release (version 50): 3315 crashes from 2016-11-01.
 - esr     (version 45): 0 crashes from 2016-07-13.

Crash volume on the last weeks (Week N is from 01-09 to 01-15):
            W. N-1  W. N-2  W. N-3  W. N-4  W. N-5  W. N-6  W. N-7
 - nightly       0       0       0       0       0       0       0
 - aurora        0       0       0       0       0       0       0
 - beta         57      45      26       9      19      36      24
 - release     658     546     461     343     339     399     280
 - esr           0       0       0       0       0       0       0

Affected platform: Windows

Crash rank on the last 7 days:
           Browser   Content   Plugin
 - nightly
 - aurora
 - beta    #441      #574
 - release #167      #172
 - esr

Comment 8

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 10

[Lee Salzman [:lsalzman]]

This was essentially already fixed prior even to 52 ESR with the patches already in this bug. All "new" reports are only on unsupported released from before then. I'm just going to close this out as fixed since it should be marked so.