1329333 - autocomplete becomes visually detached from field

Status: NEW

(Toolkit :: Form Manager, defect, P3)

Description

[Tanvi Vyas[:tanvi]]

https://irccloud.mozilla.com/file/pAROSJmq/Screenshot%202017-01-03%2012.05.19.png

Ryan found this bug in Nightly 53.  The drop down from the form field is not attached to the field itself.  This may not have to do with the insecure password warning, and may be an autocomplete issue in general.

We need to figure out the regression window.  What is the behavior in 50, 51, 52, 53.  Save two usernames/passwords in the password manager and then test the site http://kindredcocktails.com/.  Click on the username field and see where the drop down exists (attached or unattached to the form field)

Comment 1

[Tanvi Vyas[:tanvi]]

Adrian, can you take a look at this and figure out what Firefox versions are affected?  Thank you!

Comment 2

[Adrian Florinescu [:aflorinescu]]

I've tried to identify a solid STR for this bug in order to get a regression range, but I only managed to get intermittent reproduction pattern. With normal steps I couldn't reproduce it on Ubuntu 16.04 / Mac 10.10 / Windows 10. (53/52/51.)
I managed to reproduce it accidentally while I was trying to get a screen cast for another bug and only then I got the autofill to look like in :tanvi's screenshot. (maybe a focus related issue?) Further iterations related to this failed. I'll leave the NI on me until I can figure out how to reproduce it on a solid basis.

Comment 3

[ovidiu boca[:Ovidiu]]

Hi I tested this issue over and over and I think I have some steps. I can reproduce it with github.com on Mac, Windows and Ubuntu, with the site from description I wasn't able to. It might be an edge case but here are the steps: 

1. Open https://github.com/login
2. Create 2-3 user entries. 
3. Open again https://github.com/login and click on username (a dropdown with users appears)
4. Reload the page with F5, you need to push fast and many times. 

 Please also note that this issue is reproducible intermittently. In some cases I reload the page one time and the bug appears but in other cases I need to reload many times the page until I see the bug.

Comment 6

[Adam Roach [:abr]]

Assuming this is a straight-up dupe of Bug 1336753, here is a fully reliable STR:

1. Go to an insecure webpage containing a password field (e.g., http://www.w3schools.com/html/tryit.asp?filename=tryhtml_input_password)

2. Open the browser console

3. In the browser console, enter the following code:

> var box = gBrowser.getNotificationBox(); setTimeout(function(){box.appendNotification('banner','Example Banner','chrome://browser/skin/Info.png',box.PRIORITY_WARNING_MEDIUM, []);}, 5000);

4. Within 5 seconds, click on the username field. The contextual feedback should appear warning about insecure submission of passwords.

5. Wait for the notificationbox (yellow banner) to appear

6. Note that the username field has slid down, but the contextual feedback has not. The username field is now obscured and effectively impossible to use.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Intermittent issue, but annoying enough to users that there are a few duplicate bugs filed. 
Marking this fix-optional for now. Devin, leaving this to you if you'd like to investigate the underlying problem.

Comment 9

[Devin Reams]

Our team won't be able to look at existing Toolkit bugs like this one for a while. But, it definitely makes sense to, and certainly appreciate, keeping this open and prioritized for when we can.

Comment 13

[Matthew N. [:MattN]]

This was made slightly more visible with the View Saved Logins autocomplete footer since it means we auto-open the popup in more cases.

Comment 15

[Daniel Bodea [:danibodea]]

I have attempted to reproduce this issue with the steps from any of its duplicates. The login page of Atlassian found is bug 1405077 seems to constantly reproduce the issue. It appears as... the password manager's drop-dows gets displayed, then something changes on the page (elements move) and the drop-down remains in the initial, currently improper position considering the movement of the fields. I do not believe that this issue is the same issue as some of the other duplicates. I have attempted to see if this issue (on Atlassian login page) can be regressed, but it seems like not a regression: firefox60, firefox55 reproduce the issue, and firefox50 does not show the drop-down.

I also remember some similar issue reproduced while testing the password manager feature, but I could not find steps that would reproduce it constantly. I will also deem this issue intermittent.

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

This is wontfix 68 given where we are in the beta cycle.

Comment 17

[Timea Cernea [:tbabos][inactive]]

Attachment: QQ.com

Here is a more visible and visually unpleasant case on qq.com.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

We shouldn't be triaging this in "regression triage" so please don't keep marking it affected for new versions.

Comment 20

[Matthew N. [:MattN]]

The form validation popup already handles zoom and scroll changes. I'm not sure if there is anything to share with it: https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/browser/actors/FormValidationParent.jsm#129-138

Comment 21

[rdylina]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #20)

The form validation popup already handles zoom and scroll changes. I'm not sure if there is anything to share with it: https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/browser/actors/FormValidationParent.jsm#129-138

Need to somehow monitor for position changes of the input and trigger a rerender when it moves.

Comment 27

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 13 duplicates.
:sgalich, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.