1329349 - Remove test lists from urlclassifier.disallow_completions

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P3)

Description

[François Marier [:francois]]

The urlclassifier.disallow_completions pref is quite tedious to maintain. We should be able to remove the *-simple lists from it because the "simple" format doesn't have a way to express a hash prefix.

Comment 1

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 2

[Manish [:manishkk]]

Need to remove *-simple list from here:
https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#5575

Comment 3

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Manish [:manishkk] from comment #2)

Need to remove *-simple list from here:
https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#5575

Yes

Comment 4

[Manish [:manishkk]]

Attachment: Bug 1329349 - Remove test lists from urlclassifier.disallow_completions. r=dimi

Comment 5

[Manish [:manishkk]]

Do I need to set 'checkin-needed' here?

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Manish [:manishkk] from comment #5)

Do I need to set 'checkin-needed' here?

I just landed the patch, thanks :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a302c271babd
Remove test lists from urlclassifier.disallow_completions. r=dimi

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a302c271babd