Closed Bug 1329371 Opened 7 years ago Closed 5 years ago

"add www and .com" not working correctly

Categories

(SeaMonkey :: Location Bar, defect)

SeaMonkey 2.46 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: rividh, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39
Build ID: 20151103191810

Steps to reproduce:

Fresh install of 2.46 (normal, not portable) on XP64. 

Checked preference to "add www. and .com if not found" so I can just type the domain name and have the site come up.

typed "duckduckgo" into location bar. 
SM complained, "http://duckduckgo/" not found. (Well, duh.)

I then tried to check if the toggle was not being set correctly:
typed "about:config"
SM complained "http://about:config" not found. (Yes, it added http:// all by itself.)

Once this started, it reproduced with whatever was typed into the address bar. Close and restart didn't help. It also persistently tacked http:// onto about:anything


Actual results:

2.46 normal install: Initially this worked. However after one or two sites, it stopped working. Close/restart did not help. Toggling the checkbox didn't change anything, didn't matter if it was checked or not. No addons installed (because it misbehaved before I got that far).

I then tried a clean install of 2.46 Portable. Initially this also worked right, and continued to work after installing NoScript and Prefbar. Then I installed 32bit Flash plugin for portable SM, directly from the "Manage Addons" page, and "add www and com" IMMEDIATELY stopped working, and began behaving exactly as above.

Note: downloaded today, regular 2.46 from official site, portable 2.46 from portableapps.com


Expected results:

With the toggle set on, typing just the domain name should result in it being translated to the full URL. 

So if I type

example

the browser goes to http://www.example.com with no further typing or intervention from me.
90% confirmed with a private en-US x64 build:

User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48
Build identifier: 20170106113235

It doesn't add http://to about:config.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I don't see how to edit my original post, but naturally the form grabbed the info from the system I'm on. The buggy build is this one:

User agent: Mozilla/5.0 (Windows NT 5.2; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46
Build identifier: 20161213183751


This morning about:config is working normally but typing in a domain name still gets "http://duckduckgo/ not found"

NOTE that it is adding / after the domain name too, which is not normal.

What line in about:config is relevant? wanted to check if it's missing, or just not toggling.


Frank: where do I find a legit x64 build? I found lots of download sites but none I could confirm were clean builds. Do you have problems with plugins?
Its browser.fixup.alternate.enabled. Set to true. 

I just found the comment in comm-central/mozilla/docshell/base/nsDefaultURIFixup.cpp:

// Code only works for http. Not for any other protocol including https!

So it won't work for 99% of the current websites.

These also need to be set but they should be there:

browser.fixup.alternate.prefix
browser.fixup.alternate.suffix

I suspect the code got broken between 2.40 and 2.46 somewhere in the backend. First thought it was a tabbrowser patch I did but th e fixup wasn't done there. Firefox probably no longer uses it.

> Frank: where do I find a legit x64 build?

Adrians builds should be clean and you can open bugs against them:
https://l10n.mozilla-community.org/~akalla/unofficial/seamonkey/nightly/

I build my own.

>> Do you have problems with plugins?

No because I dodn't use any:) Basically only Flash and maybe Silberlight is supported with x64 builds. Starting with 2.50 only Flash with both x86 and x64.
>> Windows NT 5.2

Oh btw. XP64 and Vista are not supported for 64 bit builds and won't install. Would need a bunch of backouts from mozilla code and build system + installer changes. Not worth it.
Found it. All the fixup lines are there and set correctly. 

Is this bug going to be fixed, or is there a fixed build I can try? it's a real PITA. :)

===

I'll try Adrian's x64 builds, thanks for the link. Was about to put SM on the linux box so I'll try this version.

Do you know if x64 SM works on Server 2008? that's the only Windows I can stand to use after XP (being basically the same desktop). 

Any particular benefit to using an x64 build? I only use Prefbar, Noscript, and Flash, not concerned about other plugins. 8GB RAM on my x64 systems, if that matters.
>> Is this bug going to be fixed, 

Not until a regression is found or someone could dig deep into the code. But I have a hunch that this is no longer supported. I tried Firefox 51 and basically got the same results.
 
Rainer,

could you probably do some regression range testing for me?
Flags: needinfo?(RainerBielefeldNG)
Well, ****. And people wonder why some of us use old browsers. That's an awful thing to remove when it's been supported all the way back to Netscape 3. It's going to be **** low-vision users in particular, since confusion between , and . is a major issue there and many are not touch-typists.
Its still in the Gecko engine so it should still be supported. Lets first see where it broke. 

But the feature will become less and less useful because most websites switch to https.

FRG
In my experience it works universally with https too, because sites that use https just redirect incoming http to https. I have yet to see an exception. And is there any reason the browser can't do its own "if http fails, try https" ??
Also affects: 
2.48 Windows
2.48 linux
Clearing old NIs
Flags: needinfo?(RainerBielefeldNG)
Apparently FIXED as of 2.49.2, thanks!
Not fixed in 2.53 and I doubt in 2.49.2. duckduckgo e.g. still does does not expand.
Huh. Well, I can tell you for a fact it's working in the one I'm using at the moment:

User agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.2
Build identifier: 20180205075051

Also working on my linux box, v2.49.4 (PCLinuxOS/KDE)
Hmm funny. Tried 2.49.5 and still no go. Tried it in a new profile and works. Same in 2.53. So either NoScript or uBlock Origin probably interferes here. Looks like the bug is in fact invalid.

Rez, can you confirm this behavior?
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(rividh)
Resolution: --- → INVALID
Huh. I use NoScript (v5.0.4, basically whatever version was handy) but not uBlock Origin. It has a default profile, and my regular profile I copied from an older install (probably v2.39) 

2.49.x is the final version for WinXP, yes? so I'll install a newer SeaMonkey on the Win10 box and report back. 2.49.2 rudely dragged from one box to the other works fine.
Flags: needinfo?(rividh)
> 2.49.x is the final version for WinXP, yes? 

Yes

> so I'll install a newer SeaMonkey on the Win10 box and report back. 2.49.2 rudely dragged from one box to the other works fine.

Hmm. Does it work with NoScript active? There wasn't really anything done here in recent versions. Puzzled :)
You need to log in before you can comment on or make changes to this bug.