Closed
Bug 1329398
Opened 4 years ago
Closed 4 years ago
python/mozboot/mozboot/osx.py needs update to follow the change in Homebrew repository
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: arai, Assigned: jdj)
References
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
gps
:
review+
arai
:
feedback+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/rev/0d823cf54df53e0cea75a74adebace956bd333d8/python/mozboot/mozboot/osx.py#24 > HOMEBREW_AUTOCONF213 = 'https://raw.github.com/Homebrew/homebrew-versions/master/autoconf213.rb' the file is now 404, since homebrew-versions repository is now deprecated and it's migrating to new one https://github.com/Homebrew/homebrew-versions/commit/e50a59125d1d35215a568be069ae60b2e9489caf https://github.com/Homebrew/homebrew-core/commit/25996676ed614b5d81dd3f0591c9b045b09db0ec#diff-560e11e6f0c7cda7826403812306bb4f The URL of the new one is following: https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/autoconf%402.13.rb
|
Reporter | |
Comment 1•4 years ago
|
||
the URL should be the following (%40 => @) https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/autoconf@2.13.rb
|
|
Reporter | |
Comment 2•4 years ago
|
||
discussed with dinarte on IRC, and assigning.
Assignee: nobody → jdinartejesus
Status: NEW → ASSIGNED
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Attachment #8824652 -
Flags: review?(arai.unmht)
|
|
Reporter | |
Comment 4•4 years ago
|
||
Comment on attachment 8824652 [details] [diff] [review] Update autoconf@2.13 repository url since homebrew-version was deprecated Review of attachment 8824652 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for your patch :) looks good. forwarding to gps, since I'm not module owner here.
Attachment #8824652 -
Flags: review?(gps)
Attachment #8824652 -
Flags: review?(arai.unmht)
Attachment #8824652 -
Flags: feedback+
|
|
Assignee | |
Comment 5•4 years ago
|
||
No problem, thanks for the support [:arai]
|
||
Updated•4 years ago
|
Attachment #8824652 -
Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/196988b0ea0a Update autoconf@2.13 repository url since homebrew-version was deprecated. r=arai, gps
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/196988b0ea0a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•