Closed Bug 1329433 Opened 3 years ago Closed 3 years ago

Improve about:profiles for RTL support

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: itiel_yn8, Assigned: tomer)

References

()

Details

(Keywords: rtl)

Attachments

(2 files)

Attached image Screenshot
In bug 1322389 we changed about:profiles so it would support RTL, but paths shown in it should always appear as LTR, even if they contain RTL characters.
Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support

https://reviewboard.mozilla.org/r/103062/#review103640

::: toolkit/themes/shared/aboutProfiles.css:51
(Diff revision 1)
>    width: 0px;
>  }
>  
>  td {
>    border-color: var(--in-content-table-border-dark-color);
> +  unicode-bidi: plaintext;

This is a quick dirty fix, as the page doesn't provide different classes to cells with paths than other fields (such as the boolean value of "Is default profile". This should be enough, although not the prettiest fix. In case the page will get major redesign in the future, I guess we will have better solutions.
Assignee: nobody → tomer.moz.bugs
Status: NEW → ASSIGNED
Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support

https://reviewboard.mozilla.org/r/103064/#review104102

::: toolkit/themes/shared/aboutProfiles.css:51
(Diff revision 1)
>    width: 0px;
>  }
>  
>  td {
>    border-color: var(--in-content-table-border-dark-color);
> +  unicode-bidi: plaintext;

Can you please add some comment here explaining what this is used for?  Thanks!
Attachment #8824703 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/01050a98e53e
Improve about:profiles for RTL support r=Ehsan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/01050a98e53e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.