1329433 - Improve about:profiles for RTL support

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Itiel]

Attachment: Screenshot

In bug 1322389 we changed about:profiles so it would support RTL, but paths shown in it should always appear as LTR, even if they contain RTL characters.

Comment 1

[Tomer Cohen :tomer]

Attachment: Bug 1329433 - Improve about:profiles for RTL support

Review commit: https://reviewboard.mozilla.org/r/103064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103064/

Comment 2

[Tomer Cohen :tomer]

Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support

https://reviewboard.mozilla.org/r/103062/#review103640

::: toolkit/themes/shared/aboutProfiles.css:51
(Diff revision 1)
>    width: 0px;
>  }
>  
>  td {
>    border-color: var(--in-content-table-border-dark-color);
> +  unicode-bidi: plaintext;

This is a quick dirty fix, as the page doesn't provide different classes to cells with paths than other fields (such as the boolean value of "Is default profile". This should be enough, although not the prettiest fix. In case the page will get major redesign in the future, I guess we will have better solutions.

Comment 3

[(no longer active)]

Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support

https://reviewboard.mozilla.org/r/103064/#review104102

::: toolkit/themes/shared/aboutProfiles.css:51
(Diff revision 1)
>    width: 0px;
>  }
>  
>  td {
>    border-color: var(--in-content-table-border-dark-color);
> +  unicode-bidi: plaintext;

Can you please add some comment here explaining what this is used for?  Thanks!

Comment 4

[Tomer Cohen :tomer]

Comment on attachment 8824703 [details]
Bug 1329433 - Improve about:profiles for RTL support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103064/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01050a98e53e
Improve about:profiles for RTL support r=Ehsan

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01050a98e53e