Closed Bug 1329438 Opened 3 years ago Closed 3 years ago
Crash in ns
Window::Gecko View Support::Load Uri
This bug was filed from the Socorro interface and is report bp-fff9ab87-01f5-4f36-8894-aadb12170105. ============================================================= Looks like a nullptr dereferences. Crashes across all versions.
As a point of information, this happens to me with the following situation : -I have a shortcut on the homescreen to a website -I restart Firefox for example after an update -Firefox loads the displayed tab (in my case twitter that takes quite some time to load) -While it's loading I press home and click on my shortcut on the homescreen. That's when it crashes, after a few moment. It doesn't seem to happen if I wait that Twitter is properly loaded before loading another website.
Right now we wait until PROFILE_READY state, but we may not have a browser DOM window until RUNNING state, so wait until then.
Attachment #8833438 - Flags: review?(snorp)
Attachment #8833438 - Flags: review?(snorp) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/039a0ba190d4 Wait until Gecko is ready to open URI; r=snorp
Please request Aurora/Beta approval on this when you get a chance.
Comment on attachment 8833438 [details] [diff] [review] Wait until Gecko is ready to open URI (v1) Approval Request Comment [Feature/Bug causing the regression]: Bug 1285572 [User impact if declined]: Possible crash when launching a URL shortcut during Fennec startup [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Simple change that avoids the crash but doesn't change any other functionality [String changes made/needed]: None
Comment on attachment 8833438 [details] [diff] [review] Wait until Gecko is ready to open URI (v1) Fix a crash. Aurora53+.
Attachment #8833438 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8833438 [details] [diff] [review] Wait until Gecko is ready to open URI (v1) fix fennec crash when opening a URI, beta52+
Attachment #8833438 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.