toolkit/components/terminator/nsTerminator.cpp:218:67: error: 'AutoProfilerRegister::AutoProfilerRegister(const char*)' is private within this context (non-SPS)

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

({regression})

Trunk
mozilla53
Unspecified
FreeBSD
regression
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

Details

(Whiteboard: [npotb])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
toolkit/components/terminator/nsTerminator.cpp:218:24: error: calling a private
      constructor of class 'AutoProfilerRegister'
  AutoProfilerRegister registerThread("Shutdown Statistics Writer");
                       ^
objdir/dist/include/GeckoProfiler.h:251:3: note: implicitly declared private here
  AutoProfilerRegister(const char* aName) {}
  ^
1 error generated.
(Assignee)

Comment 1

2 years ago
In file included from objdir/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:101:
ipc/chromium/src/base/thread.cc:156:32: error: expected ';' after expression
  mozilla::AutoProfilerRegister registerThread(name_.c_str());
                               ^
                               ;
ipc/chromium/src/base/thread.cc:156:12: error: no member named 'AutoProfilerRegister' in
      namespace 'mozilla'
  mozilla::AutoProfilerRegister registerThread(name_.c_str());
  ~~~~~~~~~^
ipc/chromium/src/base/thread.cc:156:33: error: use of undeclared identifier
      'registerThread'
  mozilla::AutoProfilerRegister registerThread(name_.c_str());
                                ^
3 errors generated.
(Assignee)

Updated

2 years ago
See Also: → bug 1329291
(Assignee)

Comment 2

2 years ago
In file included from objdir/js/xpconnect/src/Unified_cpp_js_xpconnect_src0.cpp:56:
js/xpconnect/src/XPCJSContext.cpp:1169:34: error: expected ';' after expression
    mozilla::AutoProfilerRegister registerThread("JS Watchdog");
                                 ^
                                 ;
js/xpconnect/src/XPCJSContext.cpp:1169:14: error: no member named 'AutoProfilerRegister'
      in namespace 'mozilla'
    mozilla::AutoProfilerRegister registerThread("JS Watchdog");
    ~~~~~~~~~^
js/xpconnect/src/XPCJSContext.cpp:1169:35: error: use of undeclared identifier
      'registerThread'
    mozilla::AutoProfilerRegister registerThread("JS Watchdog");
                                  ^
3 errors generated.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Whiteboard: [npotb]

Comment 5

2 years ago
mozreview-review
Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

https://reviewboard.mozilla.org/r/103078/#review103672
Attachment #8824759 - Flags: review?(mstange) → review+
(Assignee)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

https://reviewboard.mozilla.org/r/103078/#review103682

::: tools/profiler/public/GeckoProfiler.h:254
(Diff revision 1)
> +namespace mozilla {
> +
>  class AutoProfilerRegister final MOZ_STACK_CLASS
>  {
> +public:
>    AutoProfilerRegister(const char* aName) {}

The constructor is `explicit` in GeckoProfilerImpl.h. Should I mark it the same here?

Comment 7

2 years ago
mozreview-review-reply
Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

https://reviewboard.mozilla.org/r/103078/#review103682

> The constructor is `explicit` in GeckoProfilerImpl.h. Should I mark it the same here?

Oh, yes please.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 9

2 years ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/51c898702340
Unbreak build on non-SPS platforms after bug 1323100. r=mstange
Keywords: checkin-needed

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/51c898702340
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee: nobody → jbeich
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
(Assignee)

Updated

2 years ago
See Also: → bug 1329467
You need to log in before you can comment on or make changes to this bug.