1329466 - toolkit/components/terminator/nsTerminator.cpp:218:67: error: 'AutoProfilerRegister::AutoProfilerRegister(const char*)' is private within this context (non-SPS)

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

toolkit/components/terminator/nsTerminator.cpp:218:24: error: calling a private
      constructor of class 'AutoProfilerRegister'
  AutoProfilerRegister registerThread("Shutdown Statistics Writer");
                       ^
objdir/dist/include/GeckoProfiler.h:251:3: note: implicitly declared private here
  AutoProfilerRegister(const char* aName) {}
  ^
1 error generated.

Comment 1

[Jan Beich]

In file included from objdir/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:101:
ipc/chromium/src/base/thread.cc:156:32: error: expected ';' after expression
  mozilla::AutoProfilerRegister registerThread(name_.c_str());
                               ^
                               ;
ipc/chromium/src/base/thread.cc:156:12: error: no member named 'AutoProfilerRegister' in
      namespace 'mozilla'
  mozilla::AutoProfilerRegister registerThread(name_.c_str());
  ~~~~~~~~~^
ipc/chromium/src/base/thread.cc:156:33: error: use of undeclared identifier
      'registerThread'
  mozilla::AutoProfilerRegister registerThread(name_.c_str());
                                ^
3 errors generated.

Comment 2

[Jan Beich]

In file included from objdir/js/xpconnect/src/Unified_cpp_js_xpconnect_src0.cpp:56:
js/xpconnect/src/XPCJSContext.cpp:1169:34: error: expected ';' after expression
    mozilla::AutoProfilerRegister registerThread("JS Watchdog");
                                 ^
                                 ;
js/xpconnect/src/XPCJSContext.cpp:1169:14: error: no member named 'AutoProfilerRegister'
      in namespace 'mozilla'
    mozilla::AutoProfilerRegister registerThread("JS Watchdog");
    ~~~~~~~~~^
js/xpconnect/src/XPCJSContext.cpp:1169:35: error: use of undeclared identifier
      'registerThread'
    mozilla::AutoProfilerRegister registerThread("JS Watchdog");
                                  ^
3 errors generated.

Comment 3

[Jan Beich]

Attachment: Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

Review commit: https://reviewboard.mozilla.org/r/103078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103078/

Comment 4

[Jan Beich]

comment 0 reproduced on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7180da60601039a88f569e38b285fbf90fde5d6e

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

https://reviewboard.mozilla.org/r/103078/#review103672

Comment 6

[Jan Beich]

Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

https://reviewboard.mozilla.org/r/103078/#review103682

::: tools/profiler/public/GeckoProfiler.h:254
(Diff revision 1)
> +namespace mozilla {
> +
>  class AutoProfilerRegister final MOZ_STACK_CLASS
>  {
> +public:
>    AutoProfilerRegister(const char* aName) {}

The constructor is `explicit` in GeckoProfilerImpl.h. Should I mark it the same here?

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

https://reviewboard.mozilla.org/r/103078/#review103682

> The constructor is `explicit` in GeckoProfilerImpl.h. Should I mark it the same here?

Oh, yes please.

Comment 8

[Jan Beich]

Comment on attachment 8824759 [details]
Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103078/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51c898702340
Unbreak build on non-SPS platforms after bug 1323100. r=mstange

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/51c898702340