Closed
Bug 1329497
Opened 4 years ago
Closed 4 years ago
uncaught exception in dom/base/test/test_viewsource_forbidden_in_object.html
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: mats, Assigned: bobowen)
Details
Attachments
(1 file)
1.63 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I just noticed this while looking through a mochitest log: > INFO - TEST-START | dom/base/test/test_viewsource_forbidden_in_object.html > INFO - JavaScript error: http://mochi.test:8888/tests/dom/base/test/test_viewsource_forbidden_in_object.html, line 19: uncaught exception: 2152398858 > INFO - JavaScript error: http://mochi.test:8888/tests/dom/base/test/test_viewsource_forbidden_in_object.html, line 19: uncaught exception: 2152398858 > INFO - JavaScript error: resource://app/components/FeedConverter.js, line 516: uncaught exception: 2152398858 > INFO - JavaScript error: resource://app/components/FeedConverter.js, line 516: NS_ERROR_MALFORMED_URI: The URI is malformed'The URI is malformed' when calling method: [nsIProtocolHandler::newURI] Is the uncaught exception expected? or is there something wrong with the test? https://treeherder.mozilla.org/logviewer.html#?job_id=67088661&repo=try&lineNumber=4885
Comment 1•4 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #0) > I just noticed this while looking through a mochitest log: > > > INFO - TEST-START | dom/base/test/test_viewsource_forbidden_in_object.html > > INFO - JavaScript error: http://mochi.test:8888/tests/dom/base/test/test_viewsource_forbidden_in_object.html, line 19: uncaught exception: 2152398858 > > INFO - JavaScript error: http://mochi.test:8888/tests/dom/base/test/test_viewsource_forbidden_in_object.html, line 19: uncaught exception: 2152398858 > > INFO - JavaScript error: resource://app/components/FeedConverter.js, line 516: uncaught exception: 2152398858 > > INFO - JavaScript error: resource://app/components/FeedConverter.js, line 516: NS_ERROR_MALFORMED_URI: The URI is malformed'The URI is malformed' when calling method: [nsIProtocolHandler::newURI] > > Is the uncaught exception expected? > or is there something wrong with the test? > Bob is the author of the test case. Let's see if he has answers. > https://treeherder.mozilla.org/logviewer. > html#?job_id=67088661&repo=try&lineNumber=4885
Flags: needinfo?(bobowencode)
Assignee | ||
Comment 2•4 years ago
|
||
I guess these errors started when Bug 1277685 landed. I think just removing those cases makes sense, since they're no longer valid URIs so no longer test this code. MozReview-Commit-ID: FSuz0zhVUNv
Attachment #8826166 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → bobowencode
Status: NEW → ASSIGNED
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(bobowencode)
![]() |
||
Comment 3•4 years ago
|
||
Comment on attachment 8826166 [details] [diff] [review] Remove object view-source tests that are no longer valid URIs >- desc: "Test 4: pcast:view-source should not be allowed in an object", >- URI: "pcast:view-source:file_general_document.html" Why is his one going away? Doe sit use the feed converter too? r=me if so, r=me with it restored if it should have stayed.
Attachment #8826166 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•4 years ago
|
||
Thanks. (In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #3) > >- desc: "Test 4: pcast:view-source should not be allowed in an object", > >- URI: "pcast:view-source:file_general_document.html" > > Why is his one going away? Doe sit use the feed converter too? Yes it goes through FeedConverter.js as well.
Assignee | ||
Comment 5•4 years ago
|
||
This only removes some now invalid test cases, so I don't think it is worth pushing to try. I have run the test locally.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3ccf0f50160 Remove object view-source tests that are no longer valid URIs. r=bz
Keywords: checkin-needed
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f3ccf0f50160
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•