1329513 - Add RemoveRawOrSmartPointer<T> to remove raw and smart pointers from their contained type

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Basically, a combination of RemovePointer<T> and RemoveSmartPointer<T>.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1329513 - RemoveRawOrSmartPointerHelper to extract T from T*, RefPtr<T>, and nsCOMPtr<T> -

Implemented in the same style as RemovePointer and RemoveSmartPointer, for
consistency.
It could have been done by invoking the latter two, but I didn't want to add an
unnecessary extra layer of templates; the cost of the code duplication should
be negligible.

Review commit: https://reviewboard.mozilla.org/r/103106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103106/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8824832 [details]
Bug 1329513 - RemoveRawOrSmartPointerHelper to extract T from T*, RefPtr<T>, and nsCOMPtr<T> -

https://reviewboard.mozilla.org/r/103106/#review103894

`static_assert`-style tests for this would be splendid. :)

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8824832 [details]
Bug 1329513 - RemoveRawOrSmartPointerHelper to extract T from T*, RefPtr<T>, and nsCOMPtr<T> -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103106/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2df2cb2dd088
RemoveRawOrSmartPointerHelper to extract T from T*, RefPtr<T>, and nsCOMPtr<T> - r=froydnj

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Renamed 'RemoveAnyPointer' to 'RemoveRawOrSmartPointer', as I didn't want to give the wrong impression that it could remove other types of smart pointers like UniquePtr.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2df2cb2dd088