Closed
Bug 1329515
Opened 7 years ago
Closed 7 years ago
JS Parse error in devtools/client/framework/source-map.js
Categories
(DevTools :: Debugger, defect, P4)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: florian, Assigned: jryans)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
JavaScript error: devtools/client/framework/source-map.js, line 11: SyntaxError: missing ) after formal parameters Line 11 is: return function(...args: any) { I got this error when attempting to parse the .js files of the tree using xpcshell or using Reflect.parse
Comment 1•7 years ago
|
||
This is Flow-annotated source from the new debugger. I think this particular file isn't needed; I'm not sure why it's there at all. I suspect it can simply be removed.
Priority: -- → P4
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Tom Tromey :tromey from comment #1) > This is Flow-annotated source from the new debugger. > I think this particular file isn't needed; I'm not sure why it's there at > all. > I suspect it can simply be removed. Yes, that's my understanding as well. In fact, all 3 of the following: framework/source-map.js framework/source-map-worker.js framework/source-map-util.js appear unused. It seems they were landed (maybe accidentally) in the debugger bundle update in bug 1316413. The new debugger does still use a separate worker file, but it uses the copy at debugger/new/source-map-worker.js.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Blocks: source-maps
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1f82efc53ffc4ff26e4c596fb681aacad85f9ff
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8843061 [details] Bug 1329515 - Remove unused source map modules. https://reviewboard.mozilla.org/r/116812/#review118450 Thank you.
Attachment #8843061 -
Flags: review?(ttromey) → review+
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2c60f5f03a78 Remove unused source map modules. r=tromey
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c60f5f03a78
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•