1329559 - Script Timeout of Zero

Status: RESOLVED INVALID

(Remote Protocol :: Marionette, defect)

Description

[Titus Fortner]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce:

Set Script Timeout to zero then ran an async script


Actual results:

https://gist.github.com/titusfortner/2d6eee26d768c4bfa4aa56fef16a39b4

Also of interest, I see:
"WARN	Using deprecated data structure for setting timeouts"

Looking at the spec it seems like this should be correct?
"{"type":"script","value":1}"
Marionette returns:
{"error":"invalid argument","message":"Missing 'ms' parameter"}

And ms is definitely not still in the spec



Expected results:

per spec, 0 is an integer and not less than zero, so it should be an acceptable value, and should not prevent a script from returning.

Comment 1

[Titus Fortner]

It looks like this matters specifically when it would return a Timeout Error, because setting it to zero elsewhere seems to be working as expected.

Comment 2

[Titus Fortner]

And using the remote server instead of geckodriver directly is failing regardless of whether it is set to zero. That might be a different issue.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Andreas made some changes lately to the timeouts support, which all got landed for Firefox 52 but not below. So he might give you a good answer. Otherwise please try with Firefox 52 DevEdition if it works as you expect.

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Titus Fortner from comment #0)
> Steps to reproduce:
> 
> Set Script Timeout to zero then ran an async script
> 
> Actual results:
> 
> https://gist.github.com/titusfortner/2d6eee26d768c4bfa4aa56fef16a39b4
> 
> Also of interest, I see:
> "WARN	Using deprecated data structure for setting timeouts"
> 
> Looking at the spec it seems like this should be correct?
> "{"type":"script","value":1}"

The correct data input is

   {
     "implicit: 1
     "script": 2,
     "page load": 3
   }

where the numbers are the millisecond duration values of the timeouts, and where all fields are optional.  This means you can send e.g. {"script": 42} by itself.

> Marionette returns:
> {"error":"invalid argument","message":"Missing 'ms' parameter"}
> 
> And ms is definitely not still in the spec

Marionette previously used the data input {"type": "script", ms: 42} but has since moved to the new data structure mentioned above.  The have kept the old data input for backwards compatibility reasons with our internal Firefox upgrade test.

I conclude that this bug is invalid since Marionette follows the specification.  It would seem the client should adapt and send spec-conforming input.