1329562 - Remove WebRTC checks for Windows Vista

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Firefox 52 is the last version to support Windows XP or Vista, so we can remove Windows version checks for XP, Vista, or 7.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1329562 - Part 1: Remove WebRTC checks for Vista.

Review commit: https://reviewboard.mozilla.org/r/103176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103176/

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1329562 - Part 2: Remove gUM screensharing.allow_on_old_platforms check for XP.

Review commit: https://reviewboard.mozilla.org/r/103178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103178/

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8824866 [details]
Bug 1329562 - Part 1: Remove WebRTC checks for Vista.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103176/diff/1-2/

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8824867 [details]
Bug 1329562 - Part 2: Remove gUM screensharing.allow_on_old_platforms check for XP.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103178/diff/1-2/

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8824866 [details]
Bug 1329562 - Part 1: Remove WebRTC checks for Vista.

https://reviewboard.mozilla.org/r/103176/#review103902

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8824867 [details]
Bug 1329562 - Part 2: Remove gUM screensharing.allow_on_old_platforms check for XP.

https://reviewboard.mozilla.org/r/103178/#review103904

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbe4d2f590a5
Part 1: Remove WebRTC checks for Vista. r=jesup
https://hg.mozilla.org/integration/autoland/rev/2d7af132a40c
Part 2: Remove gUM screensharing.allow_on_old_platforms check for XP. r=jesup

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bbe4d2f590a5
https://hg.mozilla.org/mozilla-central/rev/2d7af132a40c

Comment 9

[Andrei Vaida [:avaida]]

Chris, would this fix benefit from manual testing?

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to Andrei Vaida, QA [:avaida] – please ni? me from comment #9)
> Chris, would this fix benefit from manual testing?

I don't think manual testing is necessary. This was a small change.

Comment 11

[Andrei Vaida [:avaida]]

(In reply to Chris Peterson [:cpeterson] from comment #10)
> (In reply to Andrei Vaida, QA [:avaida] – please ni? me from comment #9)
> > Chris, would this fix benefit from manual testing?
> 
> I don't think manual testing is necessary. This was a small change.

Thank you for following up!