Closed Bug 1329739 Opened 3 years ago Closed 3 years ago

Specify a MixBlendMode for WebRenderLayers

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: rhunt, Assigned: rhunt)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

There are a couple of reftests in css-blending/ that are currently failing.

Specifying a WebRender::MixBlendMode should fix this.
Specifying the MixBlendMode using the Layer's gfx::CompositionOp seems to mostly work, but there seems to be a weird clipping(?) issue causing reftests to fail.

This could be an issue on the WebRender side.
Attached patch mbm1.patchSplinter Review
Attachment #8828585 - Flags: review?(bugmail)
Attached patch mbm2.patch (obsolete) — Splinter Review
Attachment #8828586 - Flags: review?(bugmail)
Attached patch mbm2.patchSplinter Review
Attachment #8828586 - Attachment is obsolete: true
Attachment #8828586 - Flags: review?(bugmail)
Attachment #8828589 - Flags: review?(bugmail)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8d671024010d85ab52b43a007b3cedb081470b9

There are two test failures in this run. One is dependent on a fix in a webrender update. The other I believe has to do with transforms which we don't handle yet, so I think it is okay to mark it as failing for now.
Depends on: 1332465
Comment on attachment 8828585 [details] [diff] [review]
mbm1.patch

Review of attachment 8828585 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. In the future please upload patches using 8 lines of context in the diff hunks, instead of 3. If you're using mercurial you can add this your ~/.hgrc to accomplish this:

[diff]
unified = 8

::: gfx/webrender_bindings/WebRenderTypes.h
@@ +33,5 @@
> +{
> +  switch (compositionOp)
> +  {
> +      case gfx::CompositionOp::OP_MULTIPLY:
> +        return  WrMixBlendMode::Multiply;

nit: just one space after "return", all the way down this function
Attachment #8828585 - Flags: review?(bugmail) → review+
Also be sure to update the commit messages from "r=kats?" to "r=kats" when landing since they have been reviewed pre-landing. Thanks!
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/projects/graphics/rev/adec37b87be4
Specify a WrMixBlendMode for WebRenderLayer r=kats
https://hg.mozilla.org/projects/graphics/rev/5a77f7c0a080
Mark 8 reftests as passing. r=kats
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/projects/graphics/rev/17813cfcb268
Mark 3 reftests as passing. rs=kats
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.