1329777 - Canvas demotion GL->Software doesn't appear to be working

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[George Wright (:gw280) (needinfo me!)]

On my machine at least (OS X), we hit this early return: http://searchfox.org/mozilla-central/source/dom/canvas/CanvasRenderingContext2D.cpp#1347

mTarget == sErrorTarget in this case.

Investigating further.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Right, I've seen the same thing; I imagine with the persistent buffer provider it is now OK to have an empty target, but a valid mBufferProvider, and we should continue if that's the case?

Comment 2

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Bug-1329777-Don-t-bail-early-from-SwitchRenderingMod.patch

I think I agree with you Milan. Looking through these changes from bug 1167235 I think that the best solution here is to check for the buffer provider in SwitchRenderingMode only. I think IsTargetValid() still makes sense to only ensure that mTarget is functioning correctly, as we use it a lot after EnsureTarget().

I don't think we need to EnsureTarget() for SwitchRenderingMode either as we snapshot off the old BufferProvider instead of the old target, so this all should keep working.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d26e43c0d5d
Don't bail early from SwitchRenderingMode unless there's also no buffer provider r=Bas

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d26e43c0d5d