Closed
Bug 1329814
Opened 7 years ago
Closed 7 years ago
fix race condition when shutting down a tab
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
880 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
When TabChild recieves the Destroy message from its parent the doc accessibles for that tab are shut down. However if the Shutdown message sent by DocAccessible::Shutdown() isn't recieved before the child process handles the runnable that sends __delete__ to the tab parent actor the parent can send a message to the already shut down doc accessible child actor.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8825223 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8825223 -
Flags: review?(bugs) → review+
Pushed by tsaunders@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c6c6a1ba1218 fix race condition when shutting down a tab r=smaug
![]() |
||
Comment 3•7 years ago
|
||
Backed out for bustage due to undeclared variables: https://hg.mozilla.org/integration/mozilla-inbound/rev/b5df9df8100004dc3e9262e10ef12392a511bd00 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c6c6a1ba12183d7e150935daff124d8fb1c85391 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=67680635&repo=mozilla-inbound /builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/TabParent.cpp:362:7: error: 'DocAccessibleParent' was not declared in this scope /builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/TabParent.cpp:362:28: error: 'tabDoc' was not declared in this scope
Flags: needinfo?(tbsaunde+mozbugs)
Pushed by tsaunders@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8cdcf83fd165 fix race condition when shutting down a tab r=smaug
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(tbsaunde+mozbugs)
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8cdcf83fd165
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•7 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•