fix race condition when shutting down a tab

RESOLVED FIXED in Firefox 53

Status

()

Core
Disability Access APIs
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
When TabChild recieves the Destroy message from its parent the doc accessibles
for that tab are shut down.  However if the Shutdown message sent by
DocAccessible::Shutdown() isn't recieved before the child process handles the
runnable that sends __delete__ to the tab parent actor the parent can send a
message to the already shut down doc accessible child actor.
(Assignee)

Comment 1

a year ago
Created attachment 8825223 [details] [diff] [review]
fix race condition when shutting down a tab
Attachment #8825223 - Flags: review?(bugs)

Updated

a year ago
Attachment #8825223 - Flags: review?(bugs) → review+

Comment 2

a year ago
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6c6a1ba1218
fix race condition when shutting down a tab r=smaug
Backed out for bustage due to undeclared variables:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5df9df8100004dc3e9262e10ef12392a511bd00

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c6c6a1ba12183d7e150935daff124d8fb1c85391
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=67680635&repo=mozilla-inbound

/builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/TabParent.cpp:362:7: error: 'DocAccessibleParent' was not declared in this scope
/builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/TabParent.cpp:362:28: error: 'tabDoc' was not declared in this scope
Flags: needinfo?(tbsaunde+mozbugs)

Comment 4

a year ago
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cdcf83fd165
fix race condition when shutting down a tab r=smaug
(Assignee)

Updated

a year ago
Flags: needinfo?(tbsaunde+mozbugs)

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8cdcf83fd165
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1330966
Depends on: 1330730
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.