1329832 - StrictMode violation, leaked contentProvider in FormHistoryRepositorySession

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P5)

Description

[:Grisha Kruglov]

01-09 17:02:05.958 3433-3441/org.mozilla.fennec_grisha E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
                                                                     java.lang.Throwable: Explicit termination method 'release' not called
                                                                         at dalvik.system.CloseGuard.open(CloseGuard.java:180)
                                                                         at android.content.ContentProviderClient.<init>(ContentProviderClient.java:81)
                                                                         at android.content.ContentResolver.acquireContentProviderClient(ContentResolver.java:1498)
                                                                         at org.mozilla.gecko.sync.repositories.android.FormHistoryRepositorySession.acquireContentProvider(FormHistoryRepositorySession.java:80)
                                                                         at org.mozilla.gecko.sync.repositories.android.FormHistoryRepositorySession.<init>(FormHistoryRepositorySession.java:104)
                                                                         at org.mozilla.gecko.sync.repositories.android.FormHistoryRepositorySession$FormHistoryRepository.createSession(FormHistoryRepositorySession.java:56)
                                                                         at org.mozilla.gecko.sync.synchronizer.SynchronizerSession.onSessionCreated(SynchronizerSession.java:324)
                                                                         at org.mozilla.gecko.sync.middleware.Crypto5MiddlewareRepository$Crypto5MiddlewareRepositorySessionCreationDelegate.onSessionCreated(Crypto5MiddlewareRepository.java:53)
                                                                         at org.mozilla.gecko.sync.repositories.Server11Repository.createSession(Server11Repository.java:64)
                                                                         at org.mozilla.gecko.sync.middleware.Crypto5MiddlewareRepository.createSession(Crypto5MiddlewareRepository.java:68)
                                                                         at org.mozilla.gecko.sync.synchronizer.SynchronizerSession.init(SynchronizerSession.java:102)
                                                                         at org.mozilla.gecko.sync.synchronizer.Synchronizer.synchronize(Synchronizer.java:86)
                                                                         at org.mozilla.gecko.sync.stage.ServerSyncStage.execute(ServerSyncStage.java:558)
                                                                         at org.mozilla.gecko.sync.stage.AbstractSessionManagingSyncStage.execute(AbstractSessionManagingSyncStage.java:41)
                                                                         at org.mozilla.gecko.sync.GlobalSession.advance(GlobalSession.java:272)
                                                                         at org.mozilla.gecko.sync.stage.ServerSyncStage.onSynchronizeFailed(ServerSyncStage.java:625)
                                                                         at org.mozilla.gecko.sync.synchronizer.Synchronizer.onSynchronizeFailed(Synchronizer.java:65)
                                                                         at org.mozilla.gecko.sync.synchronizer.ServerLocalSynchronizerSession.onSecondFlowCompleted(ServerLocalSynchronizerSession.java:71)
                                                                         at org.mozilla.gecko.sync.synchronizer.SynchronizerSession.onFlowCompleted(SynchronizerSession.java:246)
                                                                         at org.mozilla.gecko.sync.synchronizer.RecordsChannel.onStoreCompleted(RecordsChannel.java:249)
                                                                         at org.mozilla.gecko.sync.repositories.RepositorySession$1.run(RepositorySession.java:141)
                                                                         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
                                                                         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
                                                                         at java.lang.Thread.run(Thread.java:818)

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1329832 - Close a cursor after we're done with it

Removed "final" because "safeQuery" provides terrible developer ergonomics.

Review commit: https://reviewboard.mozilla.org/r/125662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125662/

Comment 2

[:Grisha Kruglov]

Err, pushed a patch to a wrong bug.

Comment 3

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.