1329859 - Remove NS_METHOD uses

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 1329857 is going to remove NS_METHOD. The handful of uses in mailnews/ can
be replaced easily.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove NS_METHOD uses

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8825270 [details] [diff] [review]
Remove NS_METHOD uses

Thanks. Looks like we should land this now since bug 1329857 has already landed and were practically busted.

Just for my education: What's NS_IMETHODIMP?

Comment 3

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/29fb1e7ca57265c7a8fcdedaac46811adcc28056

Comment 4

[Nicholas Nethercote [inactive]]

> Just for my education: What's NS_IMETHODIMP?

IDL-style methods use NS_IMETHOD for their declaration, and NS_IMETHODIMP for their definition (if they have an out-of-class definition).

NS_IMETHOD expands to |virtual nsresult|, and NS_IMETHODIMP expands to |nsresult|. And on Windows, they both also include something extra to use a different calling convention (i.e. the one used by xptcall).

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks.

Could you kindly CC or r? me in the future since I'm usually faster than Kent. I'm also the dedicated TB maintainer and looking after trunk, Aurora, Beta and ESR. I only found this bug by accident (scanning new bugs for regressions) and had I not seen it, we would have run into (yet another) bustage. Of course I know that you usually give us heads-up and patches, which is much appreciated. So thanks again.

Comment 6

[Nicholas Nethercote [inactive]]

I'll try to remember to CC Jorg next time!