Closed Bug 1329869 Opened 7 years ago Closed 5 years ago

uninstaller.nsi builds with warnings about AddTaskbarSC

Categories

(Firefox :: Installer, defect, P5)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: agashlin, Assigned: jewilde)

Details

Attachments

(1 file)

Macro MigrateTaskBarShortcut in shared.nsh uses [1] variable AddTaskbarSC, which is only defined in installer.nsi, however MigrateTaskBarShortcut is used [2] in function SetAsDefaultAppUserHKCU in shared.sh, which is included uninstaller.nsi. This results in warnings:

 1:19.79 Processing script file: "uninstaller.nsi" (ACP)
 1:20.41 warning: unknown variable/constant "AddTaskbarSC" detected, ignoring (macro:_==:1)
 1:20.44 warning: unknown variable/constant "AddTaskbarSC" detected, ignoring (macro:_==:1)
 1:20.76 warning: unknown variable/constant "AddTaskbarSC" detected, ignoring (macro:_==:1)
 1:20.79 warning: unknown variable/constant "AddTaskbarSC" detected, ignoring (macro:_==:1)

It looks like the variable could be used through: UninstallOnInitCommon -> SetAsDefaultAppUser -> SetAsDefaultAppUserHKCU -> MigrateTaskBarShortcut

This seems to have been introduced in bug 1229626.

The straightforward thing would be to add the variable to uninstaller.nsi, but I don't know if it should be used there.
Priority: -- → P5
Assignee: nobody → jewilde
Status: NEW → ASSIGNED

Fix for warnings in uninstaller.nsi for unknown variable AddTaskbarSC by adding
the variable to the nsi file rather than adding a version of MigrateTaskBarShortcut
specific to the uninstall procedure

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: