1329941 - [compact layout] Increase tile title background opacity to improve legibility

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Dão Gottwald [::dao]]

Attachment: patch

Since we render the title above the thumbnail, we need to make sure this provides enough contrast including for pathological cases with noisy thumbnails.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8825340 [details] [diff] [review]
patch

Review of attachment 8825340 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me on the assumption we 'need' to update the bg opacity to .85, though I'm curious on what kind of thumbnails this makes a difference.

Comment 2

[Dão Gottwald [::dao]]

(In reply to :Gijs from comment #1)
> Comment on attachment 8825340 [details] [diff] [review]
> patch
> 
> Review of attachment 8825340 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> rs=me on the assumption we 'need' to update the bg opacity to .85, though
> I'm curious on what kind of thumbnails this makes a difference.

from IRC:

<dao> Gijs: the STR is really just "have a tile with a noisy thumbnail, and have not so great eyesight." amazon.com works well as a testcase over here since it has black and white parts at the bottom
<dao> though this could depend on your window size, whether you're logged in on amazon, etc.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1bed58dbb66
[compact layout] Increase tile title background opacity to improve legibility. r=gijs

Comment 4

[Dão Gottwald [::dao]]

Comment on attachment 8825340 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1322718 / bug 1322738

[User impact if declined]: possible subpar legibility of about:newtab tile titles in the funnelcake build

[Is this code covered by automated tests?]: /

[Has the fix been verified in Nightly?]: not yet

[Needs manual test from QE? If yes, steps to reproduce]: probably just as part of bug 1322738

[List of other uplifts needed for the feature/fix]: /

[Is the change risky?]: no

[Why is the change risky/not risky?]: trivial adjustment of background color alpha value. The patch looks a bit larger than strictly necessary because I'm merging two CSS rules.

[String changes made/needed]: /

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b1bed58dbb66

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8825340 [details] [diff] [review]
patch

styling update for about:newtab, aurora52+/beta51+, should be in 51.0b14

Comment 7

[Dão Gottwald [::dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f02096c79bdc5ade0ad3a51eff6b11c6034bf6f

https://hg.mozilla.org/releases/mozilla-beta/rev/6e945963ef7b6b04b33ae6763cde3bde23949809

Comment 8

[Surentharan]

[bugday-20170125]