Conversation on web.whatsapp.com is not initially given display port
Categories
(Core :: Panning and Zooming, defect, P3)
Tracking
()
People
(Reporter: jnicol, Assigned: jnicol)
References
()
Details
(Keywords: perf, Whiteboard: [gfx-noted])
Attachments
(1 file)
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 6•8 years ago
|
||
Comment 7•8 years ago
|
||
mozreview-review |
Comment 8•8 years ago
|
||
Comment 9•8 years ago
|
||
Comment 10•8 years ago
|
||
mozreview-review |
Comment 11•8 years ago
|
||
Comment 12•8 years ago
|
||
Assignee | ||
Comment 13•8 years ago
|
||
mozreview-review |
Comment hidden (mozreview-request) |
Comment 15•8 years ago
|
||
Comment 16•8 years ago
|
||
mozreview-review |
Comment 17•6 years ago
|
||
Layout/base/nsLayoutUtils.cpp:3326
(Diff revision 1)
- // Only create the display port if we fall within the budget.
- bool inBudget = aBuilder.AddToDisplayPortBudget(aScrollFrame);
- if (inBudget) {
- // If we don't already have a displayport, calculate and set one.
// If we don't already have a displayport, calculate and set one.
- if (!haveDisplayPort) {
if (!haveDisplayPort) {
Tim explained on bugzilla the reason why they're this way around.
The previous code still called aBuilder.SetHaveScrollableDisplayPort() if a displayport had already been assigned for other reasons. I'm not 100% what those other reasons could be, but I think we want them counted.
The budget limit is of course tweakable but I thought that 1 x the pres context area would mean the same behaviour on the common case.
::: layout/painting/nsDisplayList.cpp:1728
https://techcloud7.org/blog/try-cool-whatsapp-statuses-love-quotes/
Updated•2 years ago
|
Assignee | ||
Comment 18•5 months ago
|
||
Lots of things have changed since this bug was filed. I'm not sure about whether the underlying display port code has changed, but importantly the symptom described by the bug is fixed by webrender - on first opening a conversation now give the scrollable content its own picture cache slice, meaning we scroll without invalidation.
Description
•