If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

tab objects returned by sessions.getRecentlyClosed are missing some data

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
WebExtensions: Compatibility
P1
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: [sessions]triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

9 months ago
When a WebExtension has the `tabs` permission and it uses sessions.getRecentlyClosed, the tabs returned by that should include:
- favIconUrl
- title
- url

but they do not. The API code should be updated to provide these, if possible.
Comment hidden (mozreview-request)
Comment on attachment 8825812 [details]
Bug 1329971 - tab objects returned by sessions.getRecentlyClosed are missing some data,

https://reviewboard.mozilla.org/r/103892/#review104756

::: browser/components/extensions/ext-utils.js:713
(Diff revision 1)
>        active: false,
>        pinned: false,
>        incognito: Boolean(tab.state && tab.state.isPrivate),
>      };
>  
> +

Nit: Remove extra newline.
Attachment #8825812 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

9 months ago
Thanks for the review, Kris. This looks good on try, so requesting check-in.
Keywords: checkin-needed

Comment 5

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/97e7ffeacda1
tab objects returned by sessions.getRecentlyClosed are missing some data, r=kmag
Keywords: checkin-needed

Comment 6

8 months ago
Patch landed few hours ago https://hg.mozilla.org/mozilla-central/rev/97e7ffeacda1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 7

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=434884f0bd1c
(Assignee)

Comment 8

8 months ago
Created attachment 8826264 [details] [diff] [review]
Uplift for 52

Approval Request Comment
[Feature/Bug causing the regression]: Bug found in sessions API, reported and fixed by bug 1329971
[User impact if declined]: Some expected tab data will not be available when calling browser.sessions.getRecentlyClosed, which could affect add-on developers using that API in their code.
[Is this code covered by automated tests?]: A new test was added along with this patch. A try run against Aurora was submitted at https://treeherder.mozilla.org/#/jobs?repo=try&revision=a887bfb08a5679ed6ee18f2d7778fa393a8a918c&selectedJob=68489140
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No. 
[Why is the change risky/not risky?]: It is a simple change to a function that is only used by the sessions API, and it is covered by a test.
[String changes made/needed]: None
Attachment #8826264 - Flags: approval-mozilla-aurora?
Comment on attachment 8826264 [details] [diff] [review]
Uplift for 52

webextensions fix for aurora52
Attachment #8826264 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ce6c527c87f0580b9f7171ac2e25aea9a707ac5d
status-firefox52: --- → fixed
You need to log in before you can comment on or make changes to this bug.