1329971 - tab objects returned by sessions.getRecentlyClosed are missing some data

Status: RESOLVED FIXED

(WebExtensions :: Compatibility, defect, P1)

Description

[Bob Silverberg [:bsilverberg]]

When a WebExtension has the `tabs` permission and it uses sessions.getRecentlyClosed, the tabs returned by that should include:
- favIconUrl
- title
- url

but they do not. The API code should be updated to provide these, if possible.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1329971 - tab objects returned by sessions.getRecentlyClosed are missing some data,

Review commit: https://reviewboard.mozilla.org/r/103892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103892/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8825812 [details]
Bug 1329971 - tab objects returned by sessions.getRecentlyClosed are missing some data,

https://reviewboard.mozilla.org/r/103892/#review104756

::: browser/components/extensions/ext-utils.js:713
(Diff revision 1)
>        active: false,
>        pinned: false,
>        incognito: Boolean(tab.state && tab.state.isPrivate),
>      };
>  
> +

Nit: Remove extra newline.

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8825812 [details]
Bug 1329971 - tab objects returned by sessions.getRecentlyClosed are missing some data,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103892/diff/1-2/

Comment 4

[Bob Silverberg [:bsilverberg]]

Thanks for the review, Kris. This looks good on try, so requesting check-in.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97e7ffeacda1
tab objects returned by sessions.getRecentlyClosed are missing some data, r=kmag

Comment 6

[Guilherme Lima]

Patch landed few hours ago https://hg.mozilla.org/mozilla-central/rev/97e7ffeacda1

Comment 7

[Bob Silverberg [:bsilverberg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=434884f0bd1c

Comment 8

[Bob Silverberg [:bsilverberg]]

Attachment: Uplift for 52

Approval Request Comment
[Feature/Bug causing the regression]: Bug found in sessions API, reported and fixed by bug 1329971
[User impact if declined]: Some expected tab data will not be available when calling browser.sessions.getRecentlyClosed, which could affect add-on developers using that API in their code.
[Is this code covered by automated tests?]: A new test was added along with this patch. A try run against Aurora was submitted at https://treeherder.mozilla.org/#/jobs?repo=try&revision=a887bfb08a5679ed6ee18f2d7778fa393a8a918c&selectedJob=68489140
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No. 
[Why is the change risky/not risky?]: It is a simple change to a function that is only used by the sessions API, and it is covered by a test.
[String changes made/needed]: None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8826264 [details] [diff] [review]
Uplift for 52

webextensions fix for aurora52

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce6c527c87f0580b9f7171ac2e25aea9a707ac5d