43 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Antenna's save_raw_crash saves raw crash metadata but also a bunch of dumps to the crash storage's store. I originally thought that all these things were part of one single unit and that it made sense to save the unit all at once every time. But maybe that's not the case. We have the idea of "this is the crash report we originally got from the client" which has a "raw_crash" part and a bunch of dumps. Later in processing, we have a "processed crash" which is the result of processing a raw crash, though in actuality, we have a bunch of different possible outputs from processing a raw crash. Those are almost entirely metadata related and don't touch the dumps. Maybe it makes sense to think of a crash report as "the original data we got from the client" plus a bunch of dumps which don't usually get updated. So then it makes sense to split save_raw_crash into save_raw_crash and maybe save_dump and have the caller iterate over all the dumps to be saved and handle the (None, '', 'upload_file_minidump') -> 'dump' name change, too. This bug covers mulling over that some more and then making whatever changes seem appropriate.
Created attachment 8825461 [details] [review] Link to Github pull-request: https://github.com/mozilla/antenna/pull/142
Landed this last week some time. Marking as FIXED.
Switching Antenna bugs to Antenna component.