If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix sync ping documentation

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

unspecified
Firefox 53
Points:
1

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8825463 [details] [diff] [review]
Fix sync ping documentation

I noticed that the current level of sync ping documentation captions are off, not working properly the readthedocs layout. Also, undefined is specified where null is used AFAICT.
Attachment #8825463 - Flags: review?(markh)
Whiteboard: [measurement:client]

Comment 2

9 months ago
Comment on attachment 8825463 [details] [diff] [review]
Fix sync ping documentation

Review of attachment 8825463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! For my info, how do we test this in the future? I tried an online rest viewer, but knowing how to test in-tree would be helpful.
Attachment #8825463 - Flags: review?(markh) → review+
The quick local way is using `mach doc`, which generates docs in `<obj>/docs/html/Mozilla_Source_Tree_Docs/`.
Sadly this doesn't exactly match the readthedocs style (e.g. doesn't have the left-hand nested TOC), but it's good enough.
Keywords: checkin-needed
Priority: -- → P1

Comment 4

9 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56c6a09d3d34
Fix sync ping documentation. r=markh.
Keywords: checkin-needed
Points: --- → 1

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/56c6a09d3d34
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.