1330064 - Change brace-style rule to allowSingleLine:false to match devtools eslint configuration

Status: RESOLVED WORKSFORME

(Toolkit :: General, defect)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1330064 - Change brace-style rule to allowSingleLine:false to match devtools eslint configuration and run --fix.

Review commit: https://reviewboard.mozilla.org/r/103626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103626/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1330064 - Manually fix brace-style allowSingleLine:false rules that --fix couldn't do automatically.

Review commit: https://reviewboard.mozilla.org/r/103628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103628/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

--fix didn't get the indentation right so I'll have to go through and fix them, hence cancelling review.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Enabling 'indent' should get us better --fix results with this rule. We should do that first.

Comment 5

[Mark Banner (:standard8)]

We replaced ESLint's formatting with prettier a while ago, and this came with it. In any case we're not likely to change things at the moment.