Closed Bug 1330082 Opened 9 years ago Closed 9 years ago

factor out a checkout_or_update function for build-clang.py

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

factor out a checkout_or_update function for build-clang.py
2.88 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
This has bugged me for a while.
It's just silly to have the same code repeated multiple times; this is the sort of thing functions were invented for.
Attachment #8825537 - Flags: review?(ehsan)
Comment on attachment 8825537 [details] [diff] [review] factor out a checkout_or_update function for build-clang.py Review of attachment 8825537 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8825537 - Flags: review?(ehsan) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ecf68f71a5b factor out a checkout_or_update function for build-clang.py; r=ehsan
https://hg.mozilla.org/mozilla-central/rev/5ecf68f71a5b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: