1330188 - Add hidden prefs for adjusting the baseline and ion JIT thresholds

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[(no longer active)]

Attachment: Add hidden prefs for adjusting the baseline and ion JIT thresholds

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 8825624 [details] [diff] [review]
Add hidden prefs for adjusting the baseline and ion JIT thresholds

Review of attachment 8825624 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with priority change.

::: js/xpconnect/src/XPCJSContext.cpp
@@ +1500,5 @@
> +        JS_SetGlobalJitCompilerOption(cx, JSJITCOMPILER_BASELINE_WARMUP_TRIGGER,
> +                                      baselineThreshold);
> +    } else {
> +        JS_SetGlobalJitCompilerOption(cx, JSJITCOMPILER_BASELINE_WARMUP_TRIGGER,
> +                                      useBaselineEager ? 0 : -1);

I would expect "useBaselineEager" and "useIonEager" to override "baselineThreshold" and "ionThreshold", respectively.

Therefore, I would suggest:
> JS_SetGlobalJitCompilerOption(cx, JSJITCOMPILER_BASELINE_WARMUP_TRIGGER, useBaselineEager ? 0 : baselineThreshold);

With no need for a branch on baselineThreshold, since it is -1 by default. Similar for the Ion case.

Comment 3

[(no longer active)]

Sounds good, will do!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94d83309b443
Add hidden prefs for adjusting the baseline and ion JIT thresholds; r=sstangl

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94d83309b443