Closed Bug 1330191 Opened 5 years ago Closed 5 years ago

Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

RESOLVED FIXED
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Callek)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=67707520&repo=mozilla-central

https://archive.mozilla.org/pub/mobile/tinderbox-builds/mozilla-central-l10n/mozilla-central-android-api-15-l10n_5-unknown-bm71-build1-build0.txt.gz

Tomorrow we find out whether the summary needs to have "on nightlies triggered through self-serve" added to it or not.
Comment on attachment 8825816 [details]
Bug 1330191 - Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long.

https://reviewboard.mozilla.org/r/103896/#review104566

Overall this looks good to me. Just one question that you may already have an answer to.

::: testing/mozharness/scripts/mobile_l10n.py:371
(Diff revision 1)
>              replace_dict['user_repo_override'] = c['user_repo_override']
> -            # deepcopy() needed because of self.config lock bug :(
> -            for repo_dict in deepcopy(c['repos']):
> -                repo_dict['repo'] = repo_dict['repo'] % replace_dict
> -                repos.append(repo_dict)
> -        else:
> +        # this is OK so early because we get it from buildbot, or
> +        # the command line for local dev
> +        replace_dict['revision'] = self._query_revision()
> +
> +        for repository in c['repos']:

Are you sure you no longer need the deepcopy in c['repos'] here? I'm not sure what the self.config lock bug refers to in the previous comment, but I don't see how this patch would otherwise work around it.
Attachment #8825816 - Flags: review+
Comment on attachment 8825816 [details]
Bug 1330191 - Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long.

https://reviewboard.mozilla.org/r/103896/#review104566

> Are you sure you no longer need the deepcopy in c['repos'] here? I'm not sure what the self.config lock bug refers to in the previous comment, but I don't see how this patch would otherwise work around it.

Yes, (a) This is the code used in desktop_l10n.py which doesn't use deepcopy. (b) This is setting new dicts with direct value replacement, rather than trying to modify in place, like was happening before.
Comment on attachment 8825816 [details]
Bug 1330191 - Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long.

Please, re-review this (first patch was incomplete due to accidentally not hitting "Save" first.
Attachment #8825816 - Flags: review+ → review?(mshal)
Comment on attachment 8825816 [details]
Bug 1330191 - Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long.

https://reviewboard.mozilla.org/r/103896/#review104674

::: testing/mozharness/scripts/mobile_l10n.py:252
(Diff revisions 1 - 2)
>              m = r.match(line)
>              if m:
>                  self.buildid = m.groups()[0]
>          return self.buildid
>  
>      def query_revision(self):

Since this code is now basically identicaly with desktop_l10n.py, please file a followup to share the two query_revision functions. No need to block on fixing this now, though.
Attachment #8825816 - Flags: review?(mshal) → review+
Comment on attachment 8825816 [details]
Bug 1330191 - Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long.

https://reviewboard.mozilla.org/r/103896/#review104674

> Since this code is now basically identicaly with desktop_l10n.py, please file a followup to share the two query_revision functions. No need to block on fixing this now, though.

I'll be gutting much of this code, and unifying it as part of my overall plan, so I won't file the bug specifically for this comment but I can assure that it will happen.
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0761d9bf56c4
Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long. r=mshal
(In reply to Pulsebot from comment #9)
> Pushed by Callek@gmail.com:
> https://hg.mozilla.org/integration/autoland/rev/0761d9bf56c4
> Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment
> 12-40 characters long. r=mshal

Wes promised he'd make this patch land before his EOD, (either by graft or merge), so its in tomorrow's nightly.

n-i to him to ensure that.
Flags: needinfo?(wkocher)
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/13603af3862d
Android l10n nightlies fail with abort: --revision must be a SHA-1 fragment 12-40 characters long. r=mshal a=merge
https://hg.mozilla.org/mozilla-central/rev/13603af3862d9583ed2feefb06e0988c2d7fed8c

Grafted this manually from autoland because I didn't get a merge in today. There'll likely be another comment when the merge officially gets the original landing over to mozilla-central.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(wkocher)
Resolution: --- → FIXED
i guess this cause https://treeherder.mozilla.org/logviewer.html#?job_id=68381306&repo=mozilla-central now
Status: RESOLVED → REOPENED
Flags: needinfo?(bugspam.Callek)
Resolution: FIXED → ---
Sorry for that...

https://hg.mozilla.org/mozilla-central/rev/1289b60bd5ed221f6713497fcdc8167ae3896916
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Flags: needinfo?(bugspam.Callek)
Resolution: --- → FIXED
Pushed by Callek@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/6e5f04db4c4a
Another Bustage fix from Bug 1330191. r=me, a=philor
Assignee: nobody → bugspam.Callek
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.