1330196 - [jsplugins] Can not render pdf with latest PDFium binary

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Louis Chang [:louis]]

We can not normally render the pdf with the latest PDFium binary. The page is blank but UI is still there. We should dig into the problem see if there is anything we can fix in runtime.

Comment 1

[Louis Chang [:louis]]

We can not normally render the pdf with the PDFium binary which is built after 2016, Nov 15.

Comment 2

[Louis Chang [:louis]]

Attachment: Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun

Hi Bruce,

Would you please review the patch? The patch fixes the rendering problem with latest PDFium binary.

Recently, Chromium improves pinch-zoom for PDF [1]. PostMessage of type viewport takes an addition parameter pinchPhase. We workaround here by adding a pinchPhase of value 0 to make sure that viewing pdf works normally. 

[1] Chromium revision: 6e1abbfb2450eedddb1ab128be1b31cc93104e41

Comment 3

[Bruce Sun [:brsun]]

Comment on attachment 8835446 [details] [diff] [review]
Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun

Review of attachment 8835446 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Bruce Sun [:brsun]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80e155870904fbec43dfe981077df3475e0d2c87
Bug 1330196 - Can not render pdf with latest PDFium binary. r=brsun

Comment 5

[Bruce Sun [:brsun]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=80e155870904fbec43dfe981077df3475e0d2c87

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80e155870904