[jsplugins] Can not render pdf with latest PDFium binary

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lochang, Assigned: lochang)

Tracking

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We can not normally render the pdf with the latest PDFium binary. The page is blank but UI is still there. We should dig into the problem see if there is anything we can fix in runtime.
(Assignee)

Updated

2 years ago
Assignee: nobody → lochang
No longer depends on: 1330182
(Assignee)

Comment 1

2 years ago
We can not normally render the pdf with the PDFium binary which is built after 2016, Nov 15.
(Assignee)

Comment 2

2 years ago
Created attachment 8835446 [details] [diff] [review]
Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun

Hi Bruce,

Would you please review the patch? The patch fixes the rendering problem with latest PDFium binary.

Recently, Chromium improves pinch-zoom for PDF [1]. PostMessage of type viewport takes an addition parameter pinchPhase. We workaround here by adding a pinchPhase of value 0 to make sure that viewing pdf works normally. 

[1] Chromium revision: 6e1abbfb2450eedddb1ab128be1b31cc93104e41
Attachment #8835446 - Flags: review?(brsun)
Comment on attachment 8835446 [details] [diff] [review]
Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun

Review of attachment 8835446 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8835446 - Flags: review?(brsun) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Attachment #8835446 - Attachment description: Bug 1330196 - Can not render pdf with latest PDFium binary → Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/80e155870904
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.