Closed
Bug 1330208
Opened 8 years ago
Closed 7 years ago
Add issue resolution button "Fixed in upcoming commit"
Categories
(MozReview Graveyard :: Review Board: User Interface, enhancement)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: mozbugz, Unassigned)
Details
Currently each issue offers two resolution buttons: "Fixed" and "Drop".
My workflow is usually to first fix all (valid) reported issues locally, and then push all fixed patches at once.
My problem is that I'd like to keep track of what I have already fixed locally, while I am working on all issues. But:
- If I don't click "Fixed", I may come back to it later on (I'm forgetful!), and find out that it's already fixed, wasting some of my time.
- If I click "Fixed" (which is what I do now), it may give the wrong impression to the world that the issue is already fixed, so why hasn't it autolanded yet?
So it would be great if there was another button "Fixed in upcoming commit" (or similar*), showing that the developer has prepared a local fix, but still preventing auto-landing. Give it an orange light?
* Please don't name it "Fixed in next commit", and it could be confusingly thought as the next commit (N+1) in the current list of patches.
And then next time I actually push to review, it will change to "Fixed"/green.
Ideally automatically; or if easier to start with, keep a "Fixed" button (next to "Re-open"), so I can go through all patches and click it myself.
Comment 1•7 years ago
|
||
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•