All users were logged out of Bugzilla on October 13th, 2018

Port |Bug 1329320 - Rewrite makecab in Rust| to TB

RESOLVED FIXED in Thunderbird 53.0

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

2 years ago
The first attempt failed
https://hg.mozilla.org/comm-central/rev/af3eeb650c062fa26e209e307090f45f57af3cdd
with

checking for Windows SDK... 0x0a00 in c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/vs2015u3/SDK
checking for Universal CRT SDK... 10.0.14393.0 in c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/vs2015u3/SDK
checking for the Debug Interface Access SDK... c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/vs2015u3/DIA SDK
checking for mt... c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/vs2015u3/SDK/bin/x64/mt.exe
checking whether MT is really Microsoft Manifest Tool... yes
checking for link... c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/vs2015u3/VC/bin/amd64_x86/link.exe
checking for makecab... not found
DEBUG: makecab: Trying c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mozilla/makecab.exe
ERROR: Cannot find makecab
*** Fix above errors and then restart with\
               "c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mozmake.exe -f client.mk build"
c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/client.mk:360: recipe for target 'configure' failed
mozmake.exe[2]: Leaving directory 'c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build'

Looks like more stuff needs porting here, like:
https://hg.mozilla.org/mozilla-central/rev/e31b6b05ba5b#l5.13 and
https://hg.mozilla.org/mozilla-central/rev/e31b6b05ba5b#l6.12

Don't the clang.manifest files also need porting?
(Assignee)

Comment 1

2 years ago
Created attachment 8825704 [details] [diff] [review]
makecab.patch

I missed the change in mozconfig.win-common. All other should not be needed (hopefully) as they are used automatically.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8825704 - Flags: review?(jorgk)
(Assignee)

Comment 2

2 years ago
This is also the file the other platforms show in check-sync-dir.
(Reporter)

Comment 3

2 years ago
Comment on attachment 8825704 [details] [diff] [review]
makecab.patch

Right, we don't have clang.manifest in comm-central\mail\config\tooltool-manifests\win64 and windows.configure is also M-C only.

Fingers crossed ;-)

Please change the checkin comment to:
Bug 1330250 - Port bug 1329320 (follow-up): export MAKECAB in mozconfig.win-common. r=jorgk
(please remove space after the =).
Attachment #8825704 - Flags: review?(jorgk) → review+
(Assignee)

Comment 4

2 years ago
Yeah, fingers crossed $topsrcdir points to the correct position in our environment.

https://hg.mozilla.org/comm-central/rev/9222773dd8c9f420566b5d7ff4a529e23211fa0f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
(Reporter)

Comment 5

2 years ago
(In reply to Richard Marti (:Paenglab) from comment #4)
> Yeah, fingers crossed $topsrcdir points to the correct position in our
> environment.

Sadly not:
checking for makecab... not found
DEBUG: makecab: Trying c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/makecab.exe
ERROR: Cannot find makecab
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

2 years ago
M-c has the makecab.exe in /build/src
INFO -  checking for makecab... c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/makecab.exe

and c-c searches it in /build/mozilla
DEBUG: makecab: Trying c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mozilla/makecab.exe

Aleth, do you know how we could fix this?
Flags: needinfo?(aleth)

Comment 7

2 years ago
(In reply to Richard Marti (:Paenglab) from comment #6)
> M-c has the makecab.exe in /build/src
> INFO -  checking for makecab...
> c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/makecab.exe
> 
> and c-c searches it in /build/mozilla
> DEBUG: makecab: Trying
> c:/builds/moz2_slave/tb-c-cen-w32-00000000000000000/build/mozilla/makecab.exe
> 
> Aleth, do you know how we could fix this?

I think so, I can take a look later.
Flags: needinfo?(aleth)

Updated

2 years ago
Blocks: 1329320
(Assignee)

Comment 9

2 years ago
Created attachment 8825739 [details] [diff] [review]
Bug1330250.patch

This is what was previously checked-in as a base to work on.
Attachment #8825704 - Attachment is obsolete: true

Comment 10

2 years ago
This will require a m-c patch to fix. Backing out the c-c patches should unblock c-c for now, albeit with yellow B's.

Comment 11

2 years ago
m-c patch up. I don't think Windows will build properly without it, if you really need to work with c-c tip on Windows, use try and apply the patch from the blocking bug.
(Assignee)

Comment 12

2 years ago
Created attachment 8825743 [details] [diff] [review]
Bug1330250.patch

Patch with the changes from aleth in blocking bug to be ready when it lands in m-c.
Attachment #8825739 - Attachment is obsolete: true
Attachment #8825743 - Flags: review?(aleth)

Updated

2 years ago
Attachment #8825743 - Flags: review?(aleth) → review+
(Assignee)

Comment 14

2 years ago
Aleth's fix landed in m-c.

https://hg.mozilla.org/comm-central/rev/4eeb3f3d3ec60193f6c908170a202c20b649f390
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.