1330254 - Move MDSM::Ensure{Audio,Video}DecodeTaskQueued into DecodingState

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1330254. Part 1 - move MDSM::Ensure{Audio,Video}DecodeTaskQueued into DecodingState.

Review commit: https://reviewboard.mozilla.org/r/104064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104064/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1330254. Part 2 - move NeedToSkipToNextKeyframe() into DecodingState and remove some checks for mState.

Review commit: https://reviewboard.mozilla.org/r/104066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104066/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1330254. Part 3 - remove some checks from NeedToSkipToNextKeyframe().

1. we assert mSentFirstFrameLoadedEvent in DecodingState::Enter()
2. NeedToSkipToNextKeyframe() is called by EnsureVideoDecodeTaskQueued() when IsVideoDecoding() is true.

Review commit: https://reviewboard.mozilla.org/r/104068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104068/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1330254. Part 4 - let Handle{Audio,Video}Canceled and Handle{Audio,Video}Waited call Request{Audio,Video}Data instead.

The same reason as bug 1329897 P3.

Review commit: https://reviewboard.mozilla.org/r/104070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104070/

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8826020 [details]
Bug 1330254. Part 1 - move MDSM::Ensure{Audio,Video}DecodeTaskQueued into DecodingState.

https://reviewboard.mozilla.org/r/104064/#review104850

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8826021 [details]
Bug 1330254. Part 2 - move NeedToSkipToNextKeyframe() into DecodingState and remove some checks for mState.

https://reviewboard.mozilla.org/r/104066/#review104878

Comment 7

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8826023 [details]
Bug 1330254. Part 4 - let Handle{Audio,Video}Canceled and Handle{Audio,Video}Waited call Request{Audio,Video}Data instead.

https://reviewboard.mozilla.org/r/104070/#review104880

Comment 8

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8826022 [details]
Bug 1330254. Part 3 - remove some checks from NeedToSkipToNextKeyframe().

https://reviewboard.mozilla.org/r/104068/#review104882

Looks good to me here.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab918aa8e59b
Part 1 - move MDSM::Ensure{Audio,Video}DecodeTaskQueued into DecodingState. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/bfc46e0cfc33
Part 2 - move NeedToSkipToNextKeyframe() into DecodingState and remove some checks for mState. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/2d1240cfb011
Part 3 - remove some checks from NeedToSkipToNextKeyframe(). r=kikuo
https://hg.mozilla.org/integration/autoland/rev/1670628877e1
Part 4 - let Handle{Audio,Video}Canceled and Handle{Audio,Video}Waited call Request{Audio,Video}Data instead. r=kikuo

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ab918aa8e59b
https://hg.mozilla.org/mozilla-central/rev/bfc46e0cfc33
https://hg.mozilla.org/mozilla-central/rev/2d1240cfb011
https://hg.mozilla.org/mozilla-central/rev/1670628877e1