Closed
Bug 1330329
Opened 7 years ago
Closed 7 years ago
set bug_components for talos tests and other testing/ directories in moz.build files
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
3.39 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
in a previous bug (bug 1326465), I forgot to |hg add testing/moz.build|, I am adding that now as well as annotating specific talos tests to the proper components.
Component: Talos → General
Summary: set bug_components for talos tests in moz.build files → set bug_components for talos tests and other testing/ directories in moz.build files
Assignee | ||
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8825854 [details] [diff] [review] update testing/* components to be more accurate Review of attachment 8825854 [details] [diff] [review]: ----------------------------------------------------------------- I'm cannot confirm that all the components are "correct" but they seem reasonable to me - good stuff! Consider adding a default for testing/** of Testing : General. As it is, there are a few testing files without components still (eg testing/README.txt). Consider using Firefox for Android : Testing for the remote*.py harnesses. ::: testing/moz.build @@ +61,5 @@ > +with Files("specialpowers/**"): > + BUG_COMPONENT = ("Testing", "Mochitest") > + > +# TODO: consider creating a crashtest component in bugzilla > +# TODO: should this go in testing::general? Do you want to check in the TODOs? I think Testing : Reftest is appropriate.
Attachment #8825854 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 4•7 years ago
|
||
thanks gbrown. I would like to do testing/** but web-platform-tests/ still has a lot of work to do- maybe just filing a bug for that would suffice- thoughts? I will adjust the remote*.py data as well and remove the todo items and stick with reftest.
Comment 5•7 years ago
|
||
I just think eventually we want to have testing/** covered. You could do that now and file a bug for web-platform-tests, or work on getting web-platform-tests sorted out first -- whatever is going to work best for you.
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9f7262e1cdf set bug_components for talos tests in moz.build files. r=gbrown
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e9f7262e1cdf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•