Closed Bug 1330359 Opened 3 years ago Closed 3 years ago

storage/TelemetryVFS.cpp:130:34: error: private field 'op' is not used (non-SPS)

Categories

(Core :: Gecko Profiler, defect)

Unspecified
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jbeich, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

$ echo ac_add_options --enable-warnings-as-errors >>.mozconfig
$ ./mach build
[...]
storage/TelemetryVFS.cpp:130:34: error: private field 'op' is not used
      [-Werror,-Wunused-private-field]
  IOInterposeObserver::Operation op;
                                 ^
1 error generated.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4ac100d7ad97a7ccc81d747b46d744042de5716
In file included from objdir/layout/base/Unified_cpp_layout_base0.cpp:74:
layout/base/PresShell.cpp:9024:11: error: unused variable 'uri' [-Werror,-Wunused-variable]
  nsIURI *uri = mDocument->GetDocumentURI();
          ^
1 error generated.
Building Tier1 in non-SPS mode (NPOTB) succeeded only to fail running tests. Probably a MOZ_AUTOMATION bug as tests should run in a separate step, not as part of build.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5facc151a522931a5e8feb98c4da5ab4fe4c577b
No longer blocks: 902587
Comment on attachment 8825900 [details]
Bug 1330359 - Fix building with -Werror for non-SPS platforms.

https://reviewboard.mozilla.org/r/103974/#review106236
Attachment #8825900 - Flags: review?(mstange) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2cb610bc9eb2
Fix building with -Werror for non-SPS platforms. r=mstange
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2cb610bc9eb2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1347661
Blocks: buildwarning
You need to log in before you can comment on or make changes to this bug.