1330365 - Use mozilla::TimeStamp instead of NSPR's PRIntervalTime for OCSP timeout code

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

mozilla::TimeStamp is generally superior to PRIntervalTime, and switching lets us get rid of yet another NSPR dependency.

Comment 1

[:Cykesiopka]

Attachment: Bug 1330365 - Use mozilla::TimeStamp instead of NSPR's PRIntervalTime for OCSP timeout code.

mozilla::TimeStamp is generally superior to PRIntervalTime, and switching lets
us get rid of yet another NSPR dependency.

This patch also:
 1. Gets rid of code in nsNSSHttpRequestSession::createFcn() that limits the
    max OCSP timeout. This is a relic from when NSS was used for OCSP requests,
    and is no longer necessary.
 2. Converts all uses of PR_NOT_REACHED() to MFBT asserts while we're nearby.

Review commit: https://reviewboard.mozilla.org/r/104698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104698/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8826822 [details]
Bug 1330365 - Use mozilla::TimeStamp instead of NSPR's PRIntervalTime for OCSP timeout code.

https://reviewboard.mozilla.org/r/104698/#review106120

Cool - r=me.

Comment 3

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9413d37068adb90230ff813084c90dd6d4eabca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4abb503bfcd
Use mozilla::TimeStamp instead of NSPR's PRIntervalTime for OCSP timeout code. r=keeler

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c4abb503bfcd