Closed
Bug 1330388
Opened 8 years ago
Closed 8 years ago
Perfherder comparison validation incorect in case of newRevision
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ShrutiJ, Assigned: ShrutiJ)
Details
Attachments
(1 file)
Small nit in:
https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/perf/compare.js#L321.
It should be $stateParams.newRevision instead of $stateParams.originalProject.
The function definition can be found here:
https://github.com/mozilla/treeherder/blob/master/ui/js/services/perf/compare.js#L192
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → shrutijasoria1996
|
||
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8825921 [details] [review]
[treeherder] SJasoria:Bug1330388 > mozilla:master
I have made the required changes. :)
Attachment #8825921 -
Flags: review?(wlachance)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8825921 [details] [review]
[treeherder] SJasoria:Bug1330388 > mozilla:master
Looks good! I'll merge.
Attachment #8825921 -
Flags: review?(wlachance) → review+
|
||
Comment 4•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/6071271d4ed1f7c8a9bf76d589477fd934c05572
Bug 1330388 - Pass correct parameter to Perfherder comparison validator (#2080)
|
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•