Closed Bug 1330399 Opened 3 years ago Closed 3 years ago

determine proper bug_components for gfx/* files


(Core :: Graphics, defect)

Not set



Tracking Status
firefox54 --- fixed


(Reporter: jmaher, Assigned: jmaher)



(Whiteboard: gfx-noted)


(1 file, 1 obsolete file)

assuming gfx source/test files all fall under graphics, I see a list of options:
Core :: Graphics
Core :: Graphics: Layers
Core :: Graphics: Text
Core :: Graphics: WebRender

I assume gfx/layers/* would map to "graphics: layers".  I don't see obvious choices for layers or webrender.

:milan, could you give me some guidance on which source files/directories will map to which components.  I would really love to see the tests outlined as well- I do assume in general they fall into the same bugzilla component as the related source.
Flags: needinfo?(milan)
Whiteboard: gfx-noted
Graphics: WebRender is gfx/layers/wr and gfx/webrender* - but these currently only exist in a branch.

gfx/layers and gfx/ipc map to Graphics: Layers (with the WebRender exception noted above)

Graphics: Text is difficult to do based on directories; it could be gfx/thebes/*text*, gfx/thebes/*dwrite*, for example.  Probably best left to try to do manually.

Probably not much hope for doing this for tests, although that may change with webrender.
Flags: needinfo?(milan)
Attached patch annotate gfx/ with bug_component (obsolete) — Splinter Review
thanks for the information :milan, this should get us on a good start, and we can refine things later.  If you prefer I edit files in other directories, etc.- I am happy to change the patch.
Assignee: nobody → jmaher
Attachment #8826724 - Flags: review?(milan)
Comment on attachment 8826724 [details] [diff] [review]
annotate gfx/ with bug_component

Review of attachment 8826724 [details] [diff] [review]:

r+ with that text change, assuming these are case sensitive comparisons.

::: gfx/thebes/
@@ +3,5 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at
> +with Files('*text*'):

Let's make it Text, and hopefully it is case sensitive, so that we don't pick up "Context" files, which are definitely not related to text.

@@ +6,5 @@
> +with Files('*text*'):
> +    BUG_COMPONENT = ('Core', 'Graphics: Text')
> +
> +with Files('*dwrite*'):

DWrite, assuming it is case sensitive.
Attachment #8826724 - Flags: review?(milan) → review+
Thanks Milan, I have verified that I needed to be case sensitive and have updated the patch!
Attachment #8826724 - Attachment is obsolete: true
Attachment #8829209 - Flags: review+
Pushed by
determine proper bug_components for gfx/* files. r=milan
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.