Convert FindInPageBar events to bundle events

RESOLVED FIXED in Firefox 54

Status

()

Firefox for Android
GeckoView
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
Firefox 54
All
Android
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Summary: Convert FindInBar events to bundle events → Convert FindInPageBar events to bundle events
(Assignee)

Comment 1

a year ago
Created attachment 8827596 [details] [diff] [review]
1. Convert ActionBarHandler observers to events (v1)

Convert observers in ActionBarHandler.js to events that go through
WindowEventDispatcher. "TextSelection:Get" now replies through the
callback interface rather than a "TextSelection:Data" event. The patch
also adds new lazy-loading events in browser.js to replace the
lazy-loading observers that ActionBarHandler relied on.
Attachment #8827596 - Flags: review?(s.kaspari)
(Assignee)

Comment 2

a year ago
Created attachment 8827597 [details] [diff] [review]
2. Convert FindInPageBar events to bundle events (v1)

Convert events used in FindInPageBar to GeckoBundle/BundleEventListener
events. UI thread events are used because the listener performs UI
operations. FindInPageBar also sends some events like "FindInPage:Find"
from Java to Gecko; those events will be converted in another bug.
Attachment #8827597 - Flags: review?(s.kaspari)
(Assignee)

Comment 3

a year ago
Created attachment 8827640 [details] [diff] [review]
2. Convert FindInPageBar events to bundle events (v2)

Updated patch that also converts the events from Java to Gecko such as
"FindInPage:Find".
Attachment #8827640 - Flags: review?(s.kaspari)
(Assignee)

Updated

a year ago
Attachment #8827597 - Attachment is obsolete: true
Attachment #8827597 - Flags: review?(s.kaspari)

Comment 4

a year ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65b07eac83b3
1. Convert ActionBarHandler observers to events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/14bd5683877a
2. Convert FindInPageBar events to bundle events; r=sebastian

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/65b07eac83b3
https://hg.mozilla.org/mozilla-central/rev/14bd5683877a
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.