1330411 - Convert FindInPageBar events to bundle events

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Convert ActionBarHandler observers to events (v1)

Convert observers in ActionBarHandler.js to events that go through
WindowEventDispatcher. "TextSelection:Get" now replies through the
callback interface rather than a "TextSelection:Data" event. The patch
also adds new lazy-loading events in browser.js to replace the
lazy-loading observers that ActionBarHandler relied on.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Convert FindInPageBar events to bundle events (v1)

Convert events used in FindInPageBar to GeckoBundle/BundleEventListener
events. UI thread events are used because the listener performs UI
operations. FindInPageBar also sends some events like "FindInPage:Find"
from Java to Gecko; those events will be converted in another bug.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Convert FindInPageBar events to bundle events (v2)

Updated patch that also converts the events from Java to Gecko such as
"FindInPage:Find".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65b07eac83b3
1. Convert ActionBarHandler observers to events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/14bd5683877a
2. Convert FindInPageBar events to bundle events; r=sebastian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65b07eac83b3
https://hg.mozilla.org/mozilla-central/rev/14bd5683877a