Closed Bug 1330411 Opened 3 years ago Closed 3 years ago

Convert FindInPageBar events to bundle events

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Summary: Convert FindInBar events to bundle events → Convert FindInPageBar events to bundle events
Convert observers in ActionBarHandler.js to events that go through
WindowEventDispatcher. "TextSelection:Get" now replies through the
callback interface rather than a "TextSelection:Data" event. The patch
also adds new lazy-loading events in browser.js to replace the
lazy-loading observers that ActionBarHandler relied on.
Attachment #8827596 - Flags: review?(s.kaspari)
Convert events used in FindInPageBar to GeckoBundle/BundleEventListener
events. UI thread events are used because the listener performs UI
operations. FindInPageBar also sends some events like "FindInPage:Find"
from Java to Gecko; those events will be converted in another bug.
Attachment #8827597 - Flags: review?(s.kaspari)
Updated patch that also converts the events from Java to Gecko such as
"FindInPage:Find".
Attachment #8827640 - Flags: review?(s.kaspari)
Attachment #8827597 - Attachment is obsolete: true
Attachment #8827597 - Flags: review?(s.kaspari)
Attachment #8827596 - Flags: review?(s.kaspari) → review+
Attachment #8827640 - Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65b07eac83b3
1. Convert ActionBarHandler observers to events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/14bd5683877a
2. Convert FindInPageBar events to bundle events; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/65b07eac83b3
https://hg.mozilla.org/mozilla-central/rev/14bd5683877a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 54 → mozilla54
You need to log in before you can comment on or make changes to this bug.