Closed Bug 1330411 Opened 4 years ago Closed 4 years ago
In Page Bar events to bundle events
No description provided.
Summary: Convert FindInBar events to bundle events → Convert FindInPageBar events to bundle events
Convert observers in ActionBarHandler.js to events that go through WindowEventDispatcher. "TextSelection:Get" now replies through the callback interface rather than a "TextSelection:Data" event. The patch also adds new lazy-loading events in browser.js to replace the lazy-loading observers that ActionBarHandler relied on.
Attachment #8827596 - Flags: review?(s.kaspari)
Convert events used in FindInPageBar to GeckoBundle/BundleEventListener events. UI thread events are used because the listener performs UI operations. FindInPageBar also sends some events like "FindInPage:Find" from Java to Gecko; those events will be converted in another bug.
Updated patch that also converts the events from Java to Gecko such as "FindInPage:Find".
Attachment #8827640 - Flags: review?(s.kaspari)
Attachment #8827596 - Flags: review?(s.kaspari) → review+
Attachment #8827640 - Flags: review?(s.kaspari) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/65b07eac83b3 1. Convert ActionBarHandler observers to events; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/14bd5683877a 2. Convert FindInPageBar events to bundle events; r=sebastian
You need to log in before you can comment on or make changes to this bug.