Closed Bug 1330423 Opened 3 years ago Closed 3 years ago
Remove unnecessary 'virtual' keyword from various method declarations in the Mac font backend
I noticed that MacOSFontEntry::GetFontRef() is unnecessarily declared as 'virtual', which is likely to be adding unnecessary overhead when it is accessed. On going to remove that, I also see that we have the 'virtual' keyword on lots of declarations that are also marked 'override', as they're overriding virtual methods declared in gfxFontEntry. Mozilla code style says we don't need 'virtual' there, so let's remove those as well.
The only real change here is to make MacOSFontEntry::GetFontRef non-virtual; the rest are cosmetic fixes to better match the style guide.
Attachment #8825940 - Flags: review?(jmuizelaar)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8825940 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a772ea363ab231f7812753f0b77cf712423e124 Bug 1330423 - Remove redundant 'virtual' keyword from methods in the Mac font backend. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.