All users were logged out of Bugzilla on October 13th, 2018

Convert home panel events to bundle events

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

(Depends on: 1 bug)

unspecified
Firefox 54
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8827598 [details] [diff] [review]
Convert PanelInfoManager events to bundle events (v1)

Convert the "HomePanels:Data" event to a GeckoBundle/BundleEventListener
event. UI thread event is used because the listener invokes the callback
on the UI thread.
Attachment #8827598 - Flags: review?(s.kaspari)
(Assignee)

Updated

2 years ago
Summary: Convert PanelInfoManager events to bundle events → Convert home panel events to bundle events
Attachment #8827598 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 2

2 years ago
Created attachment 8829548 [details] [diff] [review]
2. Convert HomeBanner events to bundle events (v1)

Convert the events in HomeBanner to bundle events. "HomeBanner:Shown" is
removed in favor of using a callback.
Attachment #8829548 - Flags: review?(s.kaspari)
(Assignee)

Comment 3

2 years ago
Created attachment 8829549 [details] [diff] [review]
3. Convert HomePanelsManager events to bundle events (v1)

Convert events used in HomePanelsManager to bundle events. Background
thread events are used because HomePanelsManager processes panel changes
in the background thread. Changing to background thread events also lets
us make the change queue a simple ArrayList instead of a
ConcurrentLinkedQueue, because there is no longer multiple threads
involved.
Attachment #8829549 - Flags: review?(s.kaspari)
(Assignee)

Comment 4

2 years ago
Created attachment 8829550 [details] [diff] [review]
4. Convert home panel observers to events (v1)

Convert nsIObserverService observers used in home panels to events that
go through EventDispatcher.
Attachment #8829550 - Flags: review?(s.kaspari)
Attachment #8829548 - Flags: review?(s.kaspari) → review+
Attachment #8829549 - Flags: review?(s.kaspari) → review+
Attachment #8829550 - Flags: review?(s.kaspari) → review+

Comment 5

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3c8b390c953
1. Convert PanelInfoManager events to bundle events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf42119cf8af
2. Convert HomeBanner events to bundle events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/904d17b3ff1e
3. Convert HomePanelsManager events to bundle events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1089284c75
4. Convert home panel observers to events; r=sebastian

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d3c8b390c953
https://hg.mozilla.org/mozilla-central/rev/bf42119cf8af
https://hg.mozilla.org/mozilla-central/rev/904d17b3ff1e
https://hg.mozilla.org/mozilla-central/rev/3c1089284c75
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Updated

a year ago
Depends on: 1407805
You need to log in before you can comment on or make changes to this bug.