Closed
Bug 1330439
Opened 7 years ago
Closed 7 years ago
Convert home panel events to bundle events
Categories
(GeckoView :: General, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(4 files)
7.21 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
11.01 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
14.70 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
21.83 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Convert the "HomePanels:Data" event to a GeckoBundle/BundleEventListener event. UI thread event is used because the listener invokes the callback on the UI thread.
Attachment #8827598 -
Flags: review?(s.kaspari)
Assignee | ||
Updated•7 years ago
|
Summary: Convert PanelInfoManager events to bundle events → Convert home panel events to bundle events
Updated•7 years ago
|
Attachment #8827598 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 2•7 years ago
|
||
Convert the events in HomeBanner to bundle events. "HomeBanner:Shown" is removed in favor of using a callback.
Attachment #8829548 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 3•7 years ago
|
||
Convert events used in HomePanelsManager to bundle events. Background thread events are used because HomePanelsManager processes panel changes in the background thread. Changing to background thread events also lets us make the change queue a simple ArrayList instead of a ConcurrentLinkedQueue, because there is no longer multiple threads involved.
Attachment #8829549 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 4•7 years ago
|
||
Convert nsIObserverService observers used in home panels to events that go through EventDispatcher.
Attachment #8829550 -
Flags: review?(s.kaspari)
Updated•7 years ago
|
Attachment #8829548 -
Flags: review?(s.kaspari) → review+
Updated•7 years ago
|
Attachment #8829549 -
Flags: review?(s.kaspari) → review+
Updated•7 years ago
|
Attachment #8829550 -
Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d3c8b390c953 1. Convert PanelInfoManager events to bundle events; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/bf42119cf8af 2. Convert HomeBanner events to bundle events; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/904d17b3ff1e 3. Convert HomePanelsManager events to bundle events; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1089284c75 4. Convert home panel observers to events; r=sebastian
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d3c8b390c953 https://hg.mozilla.org/mozilla-central/rev/bf42119cf8af https://hg.mozilla.org/mozilla-central/rev/904d17b3ff1e https://hg.mozilla.org/mozilla-central/rev/3c1089284c75
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 54 → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•