Closed Bug 1330439 Opened 3 years ago Closed 3 years ago

Convert home panel events to bundle events

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

(Depends on 1 open bug)

Details

Attachments

(4 files)

No description provided.
Convert the "HomePanels:Data" event to a GeckoBundle/BundleEventListener
event. UI thread event is used because the listener invokes the callback
on the UI thread.
Attachment #8827598 - Flags: review?(s.kaspari)
Summary: Convert PanelInfoManager events to bundle events → Convert home panel events to bundle events
Attachment #8827598 - Flags: review?(s.kaspari) → review+
Convert the events in HomeBanner to bundle events. "HomeBanner:Shown" is
removed in favor of using a callback.
Attachment #8829548 - Flags: review?(s.kaspari)
Convert events used in HomePanelsManager to bundle events. Background
thread events are used because HomePanelsManager processes panel changes
in the background thread. Changing to background thread events also lets
us make the change queue a simple ArrayList instead of a
ConcurrentLinkedQueue, because there is no longer multiple threads
involved.
Attachment #8829549 - Flags: review?(s.kaspari)
Convert nsIObserverService observers used in home panels to events that
go through EventDispatcher.
Attachment #8829550 - Flags: review?(s.kaspari)
Attachment #8829548 - Flags: review?(s.kaspari) → review+
Attachment #8829549 - Flags: review?(s.kaspari) → review+
Attachment #8829550 - Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3c8b390c953
1. Convert PanelInfoManager events to bundle events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf42119cf8af
2. Convert HomeBanner events to bundle events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/904d17b3ff1e
3. Convert HomePanelsManager events to bundle events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1089284c75
4. Convert home panel observers to events; r=sebastian
Depends on: 1407805
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 54 → mozilla54
You need to log in before you can comment on or make changes to this bug.